Improve room selector modal

[Fenn-CS]

☑️ Resolves

• Refactor of RoomSelector
  • Use ConversationsListVirtual and ConversationSearchResult for conversations list:
    • improve accessibility, optimize rendering
    • show last message if provided ⚠️ optionally, disabled atm
    • resolve issue with immediate load of all avatars
  • Test coverage

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

Test coverage:

🚧 Tasks

• Code review
• Design review
• TODO:
  • emit full conversation instead of token on 'Select conversation' - chore(RoomSelector): reduce bundle size #11589
  • Split virtual list into two components => Conversation pulls all dependencies
  • reuse shared computed/methods between ConversationSearchResult / Conversation
  • check ConversationSearchResult component for reuse in LeftSidebar (need to provide actions)

[Antreesy]

Thanks! There are couple of things to improve here, so I'll take it over if you don't mind =)

[DorraJaouad]

BTW, Conversation can behave like ConversationSearchResult when isSearchResult is truthy and it is currently used in LeftSidebar. It would be better if we align and change to ConversationSearchResult there too and remove the prop from Conversation.

[DorraJaouad]

We need design review for adding last message to the conversations list ( cc @szaimen ). It is altering the UX a bit as user is now exposed to more information ( probably more than needed) when they are forwarding a message to a conversation or sharing a deck. Usually ( I mean in other chatting platforms), messages are not shown for such actions (user looks for the conversation name rather then last message).

[szaimen]

We need design review for adding last message to the conversations list ( cc @szaimen ). It is altering the UX a bit as user is now exposed to more information ( probably more than needed) when they are forwarding a message to a conversation or sharing a deck. Usually ( I mean in other chatting platforms), messages are not shown for such actions (user looks for the conversation name rather then last message).

The design looks good to me in general 👍

[DorraJaouad]

Tested 🦅

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!