export v2: Add --validation-mode={error,warn,skip} option
#1135
Conversation
|
Cram tests are failing because of additional output lines that aren't accounted for. There's very little discipline around stdout/stderr for output in Augur, and so in lieu of a system, I directed new output lines to stdout/stderr in line with similar messages from the existing surrounding code. In light of failures though, I may reconsider that. |
tsibley
force-pushed
the
trs/export-v2/validation-mode
branch
from
a74c9cc
to
adf7681
Compare
|
It was just a single cram test, not a whole slew of them like I assumed, so I just updated the test to account for the new output. |
tsibley
force-pushed
the
trs/export-v2/validation-mode
branch
from
adf7681
to
bb13069
Compare
tsibley
force-pushed
the
trs/better-validation-errors
branch
2 times, most recently
from
a8ea3dd
to
0f4b655
Compare
Extends the existing --skip-validation flag to be more nuanced by the addition of a "warn" mode. Our validation is improving, but not always correct. The "warn" mode allows a workflow to emit messages about validation failures, but keep going in the face of them instead of aborting the whole workflow due to a non-zero exit code. We may want to change the default mode to "warn"—at least until our validation failures have few "false positives" or "low-consequence positives" where the output files still load ok in Auspice—but I'll leave this for separate consideration. The --skip-validation flag is now an alias for --validation-mode=skip. Related-to: <#1044>
tsibley
force-pushed
the
trs/export-v2/validation-mode
branch
from
8879bac
to
816d285
Compare
Codecov ReportBase: 68.09% // Head: 68.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
+ Coverage 68.09% 68.16% +0.06%
==========================================
Files 62 62
Lines 6698 6740 +42
Branches 1641 1653 +12
==========================================
+ Hits 4561 4594 +33
- Misses 1831 1838 +7
- Partials 306 308 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Extends the existing
--skip-validationflag to be more nuanced by the addition of a "warn" mode. Our validation is improving, but not always correct. The "warn" mode allows a workflow to emit messages about validation failures, but keep going in the face of them instead of aborting the whole workflow due to a non-zero exit code.We may want to change the default mode to "warn"—at least until our validation failures have few "false positives" or "low-consequence positives" where the output files still load ok in Auspice—but I'll leave this for separate consideration.
The
--skip-validationflag is now an alias for--validation-mode=skip.Related-to: #1044
Testing
Checklist