Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export v2: Add --validation-mode={error,warn,skip} option #1135

Merged
merged 3 commits into from
Jan 27, 2023
Merged

export v2: Add --validation-mode={error,warn,skip} option #1135

merged 3 commits into from
Jan 27, 2023

Commits on Jan 27, 2023

  1. validate: Remove never-used code

    @tsibley
    tsibley committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1c3eed8 View commit details
    Browse the repository at this point in the history

  2. export v2: Add --validation-mode={error,warn,skip} option 

    Extends the existing --skip-validation flag to be more nuanced by the
addition of a "warn" mode.  Our validation is improving, but not always
correct.  The "warn" mode allows a workflow to emit messages about
validation failures, but keep going in the face of them instead of
aborting the whole workflow due to a non-zero exit code.

We may want to change the default mode to "warn"—at least until our
validation failures have few "false positives" or "low-consequence
positives" where the output files still load ok in Auspice—but I'll
leave this for separate consideration.

The --skip-validation flag is now an alias for --validation-mode=skip.

Related-to: <#1044>
    @tsibley
    tsibley committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3003592 View commit details
    Browse the repository at this point in the history

  3. Update changelog for #1135

    @tsibley
    tsibley committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    816d285 View commit details
    Browse the repository at this point in the history