Handle missing weight attributes in KDE frequency estimation #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an exception if the user has requested weighted KDE frequencies with weights that do not match any of the tips in the given tree. This commit explicitly checks for an empty dictionary of weights after filtering for representation by tips and raise an exception with a meaningful error message (instead of allowing the code to continue running and throwing a less meaningful ValueError when no valid weights remain). This commit also adds a unit test for this behavior. Closes #425.
… estimation Fixes another bug with frequency estimation caused by a mismatch in the casing of attributes attached to the nodes in the tree, weight attributes in the weights JSON, and what the estimation code originally expected.
trvrb
approved these changes
Dec 17, 2019
|
This fixes issues with seasonal flu builds (nextstrain/seasonal-flu#43). I'll merge and release v6.1.1 as bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception if the user has requested weighted KDE frequencies with
weights that do not match any of the tips in the given tree. This commit
explicitly checks for an empty dictionary of weights after filtering for
representation by tips and raise an exception with a meaningful error
message (instead of allowing the code to continue running and throwing a less
meaningful ValueError when no valid weights remain). This commit also adds a
unit test for this behavior.
Closes #425.