Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing weight attributes in KDE frequency estimation #426

Merged
merged 2 commits into from
Dec 17, 2019

Commits on Dec 16, 2019

  1. Handle missing weight attributes in KDE frequency estimation

    Throw an exception if the user has requested weighted KDE frequencies with
    weights that do not match any of the tips in the given tree. This commit
    explicitly checks for an empty dictionary of weights after filtering for
    representation by tips and raise an exception with a meaningful error
    message (instead of allowing the code to continue running and throwing a less
    meaningful ValueError when no valid weights remain). This commit also adds a
    unit test for this behavior.
    
    Closes #425.
    huddlej committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    6e006b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Do not modify the data attached to nodes in the tree during frequency…

    … estimation
    
    Fixes another bug with frequency estimation caused by a mismatch in the casing
    of attributes attached to the nodes in the tree, weight attributes in the
    weights JSON, and what the estimation code originally expected.
    huddlej committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    f7bff49 View commit details
    Browse the repository at this point in the history