Support v2 auspice JSONs in json_to_tree #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the json_to_tree utility to support v2 auspice JSONs which previously caused the tool to break. This commit minimally modifies the original function to pull out the tree information from v2 JSONs. The function does not attempt to maintain the same attribute interface between v1 and v2 JSONs. For example, the `attr` attribute from v1 JSONs is split into the `node_attrs` and `branch_attrs` attributes in v2 JSONs and the json_to_tree function does not try to force all outputs to have a unified `attr` attribute. This commit also adds a v2 tree and metadata JSON from the Zika tutorial build to the test data and doctests for the new json_to_tree support for these v2 JSONs. Closes #428.
|
Thank you John! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the json_to_tree utility to support v2 auspice JSONs which previously
caused the tool to break. This commit minimally modifies the original function
to pull out the tree information from v2 JSONs. The function does not attempt to
maintain the same attribute interface between v1 and v2 JSONs. For example, the
attrattribute from v1 JSONs is split into thenode_attrsandbranch_attrsattributes in v2 JSONs and the json_to_tree function does not try to force all
outputs to have a unified
attrattribute.This commit also adds a v2 tree and metadata JSON from the Zika tutorial build
to the test data and doctests for the new json_to_tree support for these v2
JSONs.
Closes #428.