Filter priority hotfix #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to follow.
Fixes a regression introduced by "Allow exception to bubble up when priority file is bad." (63d6cb2) which accidentally changed the return type of read_priority_scores() from defaultdict(float) to dict. The calling code looks up sequences unconditionally in the priorities dictionary and thus defaultdict(float) provides an appropriate fallback value when no priority is explicitly given in the provided file.
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 18.68% 18.68%
=======================================
Files 31 31
Lines 5053 5053
Branches 1281 1281
=======================================
Hits 944 944
Misses 4082 4082
Partials 27 27
Continue to review full report at Codecov.
|
|
Testing with ncov build now. Thanks Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes a regression introduced by "Allow exception to bubble up when
priority file is bad." (63d6cb2) which accidentally changed the return
type of
read_priority_scores()fromdefaultdict(float)to dict.The calling code looks up sequences unconditionally in the priorities
dictionary and thus
defaultdict(float)provides an appropriate fallbackvalue when no priority is explicitly given in the provided file.
Related issue(s)
Broke the nextstrain/ncov build on Augur 7.0.1.
Testing