Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter priority hotfix #530

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Filter priority hotfix #530

merged 2 commits into from
Apr 7, 2020

Commits on Apr 7, 2020

  1. Tests: Failing test for filter priorities regression 

    Fix to follow.
    @tsibley
    tsibley committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    ebc1764 View commit details
    Browse the repository at this point in the history

  2. filter: Restore default priority of 0 for missing sequences 

    Fixes a regression introduced by "Allow exception to bubble up when
priority file is bad." (63d6cb2) which accidentally changed the return
type of read_priority_scores() from defaultdict(float) to dict.

The calling code looks up sequences unconditionally in the priorities
dictionary and thus defaultdict(float) provides an appropriate fallback
value when no priority is explicitly given in the provided file.
    @tsibley
    tsibley committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8139f32 View commit details
    Browse the repository at this point in the history