-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TravisCI with GitHub Actions #796
Conversation
Interestingly, a test run failed on the Snakemake rule
Looks like something in |
38386a9
to
7ce71a4
Compare
Currently blocked by codecov/codecov-action#595. EDIT: unblocked |
92132b5
to
7b06d82
Compare
3edd8f8
to
7b06d82
Compare
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 33.79% 33.78% -0.02%
==========================================
Files 41 41
Lines 5903 5902 -1
Branches 1465 1465
==========================================
- Hits 1995 1994 -1
Misses 3825 3825
Partials 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, @victorlin! I'm still new to GitHub Actions, so I had a couple questions inline below with only one main request (to run CI on any branch without PR, too).
Looking at the logs for the CI runs that failed during your testing in this PR, it looks like GA is smart enough to catch when a specific Python version fails (e.g., 3.8) and cancel the remaining jobs before they finish. Am I interpreting that correctly?
Generally, this looks good and seems like an improvement over Travis. If you don't mind making the change to run CI on all branches, I'd be ok with you merging this.
Thanks for the review @huddlej! Requested changes are in so I'll merge now.
As soon as one job fails, it cancels the rest (default behavior with |
With #796, our CI workflow can now be run on forks of the repo. I'm currently doing development in a fork victorlin/augur, including for this PR, and CI workflows have been failing due to covtest upload failure albeit passing tests. This PR adds an extra condition on running the codecov upload and deploy step, only under the context of the main GitHub repository.
Context: for simplicity, we are migrating .travis.yml to a GitHub Actions workflow.
The new workflow does everything that the TravisCI workflow did, with a few tweaks:
codecov/codecov-action@v2
. The current TravisCI workflow implementation uses the bash uploader which is to be deprecated 2022-02-01.mamba
with channelsconda-forge
andbioconda
, resulting in some version differences from existing TravisCI implementation.devel/travis-rebuild-docker-image
to an inline script, so it's clear whereTRAVIS_AUTH_TOKEN
is coming from.Other changes:
iqtree
References:
conda-incubator/setup-miniconda@v2