Move animation options to a collapsible section #1705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-move--yho8mx
|
@jameshadfield again, unfinished, but would like to get feedback on general implementation direction. |
15 tasks
victorlin
force-pushed
the
victorlin/move-animation-options
branch
from
7017678
to
18435a6
Compare
nextstrain-bot
temporarily deployed
to
auspice-victorlin-move--yho8mx
victorlin
changed the base branch from
victorlin/move-panel-toggles
to
victorlin/move-panel-toggles-preview1
This keeps the styling closer to where it is used.
Do this by extending annotatedHeader to take an optional toggle, then using it for all available panels. Simplify headers and translations to just the panel name (e.g. Tree) instead of "Show <panel name>" / "<panel name> Options". Repurpose and move the section "Panel Options" to the top as "Layout". Conditionally render that entire section including the header.
Previously, the animation controls and options were very far away from each other. Move the options to where the controls are and make it a collapsible section. Default to the section being hidden under the assumption that this is not a commonly used feature. This allows the the default view to take up ~the same amount of vertical space as the previous layout.
victorlin
force-pushed
the
victorlin/move-animation-options
branch
from
18435a6
to
6591d18
Compare
nextstrain-bot
temporarily deployed
to
auspice-victorlin-move--yho8mx
victorlin
changed the base branch from
victorlin/move-panel-toggles-preview1
to
victorlin/move-panel-toggles
victorlin
force-pushed
the
victorlin/move-panel-toggles
branch
7 times, most recently
from
f080bcb
to
a69a067
Compare
victorlin
force-pushed
the
victorlin/move-panel-toggles
branch
3 times, most recently
from
830b73d
to
6753065
Compare
|
This was discussed on a call a while back. Efforts have shifted to the related PR #1704 and this has gotten out of sync. Once that's merged, these changes are not as needed. Maybe re-consider in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, the animation controls and options were very far away from each other. Move the options to where the controls are and make it a collapsible section.
Default to the section being hidden under the assumption that this is not a commonly used feature. This allows the the default view to take up ~the same amount of vertical space as the previous layout.
Related issue(s)
Checklist