Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move animation options to a collapsible section #1705

Closed
wants to merge 5 commits into from
Closed

Move animation options to a collapsible section #1705

wants to merge 5 commits into from

Commits on Oct 12, 2023

  1. panel-toggles: Add context to implicit behavior

    @victorlin
    victorlin committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    71b53a2 View commit details
    Browse the repository at this point in the history

  2. annotatedHeader: Convert to TypeScript

    @victorlin
    victorlin committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a945601 View commit details
    Browse the repository at this point in the history

  3. annotatedHeader: Use separate styled component for font-related styles 

    This keeps the styling closer to where it is used.
    @victorlin
    victorlin committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d5ee1e1 View commit details
    Browse the repository at this point in the history

  4. Move panel toggles to control headers 

    Do this by extending annotatedHeader to take an optional toggle, then
using it for all available panels.

Simplify headers and translations to just the panel name (e.g. Tree)
instead of "Show <panel name>" / "<panel name> Options".

Repurpose and move the section "Panel Options" to the top as "Layout".
Conditionally render that entire section including the header.
    @victorlin
    victorlin committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9838191 View commit details
    Browse the repository at this point in the history

  5. [wip] Move animation options to a collapsible section 

    Previously, the animation controls and options were very far away from
each other. Move the options to where the controls are and make it a
collapsible section.

Default to the section being hidden under the assumption that this is
not a commonly used feature. This allows the the default view to take up
~the same amount of vertical space as the previous layout.
    @victorlin
    victorlin committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6591d18 View commit details
    Browse the repository at this point in the history