fix(static-site): remove gatsby-inlined-css #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Gatsby v2 CSS is inlined automagically and the explicit setup relying on existence of `public/styles.css` (previously containing a portion of styles to be inlined) is no longer necessary, and even worse, fails the production build with an error: > Cannot find module '!raw-loader!../public/styles.css'. This removes the explicit setup and resolves the error. See discussion in: - #104 - #75 (comment) Relevant gatsby docs: - https://www.gatsbyjs.org/docs/migrating-from-v1-to-v2/#remove-inlined-css-in-htmljs Resolves #104
|
It is recommended to clear Gatsby's cache in or, if you have |
jameshadfield
temporarily deployed
to
nextstrain-s-fix-remove-8wu7rj
|
Tested via https://nextstrain-s-fix-remove-8wu7rj.herokuapp.com/ & all looks good. Thanks @ivan-aksamentov 👍
Sort-of -- the error log was printed from a catch block & didn't cause the built to fail. Much cleaner to have this all removed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Gatsby v2 CSS is inlined automagically and the explicit setup relying on existence of
public/styles.css(previously containing a portion of styles to be inlined) is no longer necessary, and, even worse, fails the production build with an error:because
public/styles.cssis no longer provided by Gatsby v2.This PR removes the explicit setup and resolves the error. Complements #75. Resolves #104.
See discussion in:
Relevant gatsby docs: