Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(static-site): add polyfills and target config for Internet Explorer #109

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix(static-site): add polyfills and target config for Internet Explorer #109

merged 1 commit into from
Jan 30, 2020

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jan 30, 2020 •
edited
Loading

This resolves nexstrain.org main page crash with console errors when using IE browser.

Changes:

  • added polyfill for fetch
  • changed babel's transpilation target to cover 99% of active browsers, including IE versions above 9 (inclusive).

Note: On this particular commit build is failing, until #104 is resolved. However I made it independent on the fix #108 to avoid collisions in case someone will have the build issues resolved earlier.

Verified with

  • Internet Explorer 10.0.9200.17457
  • Internet Explorer 11.0.9600.18920

@ivan-aksamentov
fix(static-site): add polyfills and target config for Internet Explorer
9349534 
This resolves nexstrain.org main page crash with console errors when using IE browser.

Changes:
 - added polyfill for `fetch`
 - changed babel's transpilation target to cover 99% of active browsers, including IE versions above 9 (inclusive).

Note: On this particular commit build is failing, until #104 is resolved. However I made it independent on the fix #108
to avoid collisions in case someone will have the build issues resolved earlier.
@ivan-aksamentov
Copy link
Member Author

There are still styling issues on internet explorer, such as

but at least it does not crash on the main page.

@jameshadfield jameshadfield temporarily deployed to nextstrain-s-fix-ie-cra-slcjxn January 30, 2020 22:30 Inactive
@jameshadfield jameshadfield changed the base branch from master to fix-ie-crash January 30, 2020 22:47
@jameshadfield jameshadfield changed the base branch from fix-ie-crash to master January 30, 2020 22:48
@jameshadfield
Copy link
Member

Tested with no regressions on MacOS / Firefox 72. I don't have IE / Edge to test on, but it's important for Nextstrain to work here as they are used in various public health agencies, so merging. Thanks @ivan-aksamentov

@jameshadfield jameshadfield merged commit b73f610 into nextstrain:master Jan 30, 2020
@ivan-aksamentov
Copy link
Member Author

@jameshadfield it is also worth checking how Safari is managing.

It is not uncommon for researchers, medical professionals and even some engineers to use outdated versions of MacOS and Safari, because they disable updates right after purchase.

For example, Safari only shipped fetch() in March 2017.
https://caniuse.com/#feat=fetch
So the Safari folks on pre-2017 Macs with updates disabled were unable to use nextstrain.org until this PR. There are many more missing features and bugs in Safari.

"Safari is the new IE" (C) everybody

@ivan-aksamentov ivan-aksamentov mentioned this pull request Jan 30, 2020
Merged
@ivan-aksamentov ivan-aksamentov deleted the fix/ie-crash branch February 2, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-aksamentov @jameshadfield