Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit config #9

Closed
4 tasks done
genehack opened this issue May 20, 2024 · 0 comments
Closed
4 tasks done

Add pre-commit config #9

genehack opened this issue May 20, 2024 · 0 comments
Assignees
@genehack
Labels
enhancement New feature or request

Comments

@genehack
Copy link
Contributor

genehack commented May 20, 2024 •
edited
Loading

  • add a .pre-commit-config.yaml
  • update README to document usage
  • make the linter happy
  • review the rules in .pre-commit-config.yaml and remove anything that auto-re-formats files (e.g., yamlfmt needs to go, fur shure...)
@genehack genehack added the enhancement New feature or request label May 20, 2024
genehack added a commit that referenced this issue May 20, 2024
@genehack
add pre-commit-config [#9]
c3f4083
genehack added a commit that referenced this issue May 20, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
923ca6c
genehack added a commit that referenced this issue May 20, 2024
@genehack
Remove execute bit from non-executable files [#9]
5328ee5
@genehack genehack mentioned this issue May 20, 2024
Merged
genehack added a commit that referenced this issue May 21, 2024
@genehack
Add pre-commit documentation to README [#9]
b4c8acf
@genehack genehack self-assigned this May 21, 2024
genehack added a commit that referenced this issue May 21, 2024
@genehack
add pre-commit-config [#9]
48b0bce
genehack added a commit that referenced this issue May 21, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
8478393
genehack added a commit that referenced this issue May 21, 2024
@genehack
Remove execute bit from non-executable files [#9]
052f12e
genehack added a commit that referenced this issue May 21, 2024
@genehack
Fix typo [#9]
ac0df56
genehack added a commit that referenced this issue May 21, 2024
@genehack
Add pre-commit documentation to README [#9]
16deee9
genehack added a commit that referenced this issue May 21, 2024
@genehack
add pre-commit-config [#9]
dffed4c
genehack added a commit that referenced this issue May 21, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
3aee504
genehack added a commit that referenced this issue May 21, 2024
@genehack
Remove execute bit from non-executable files [#9]
1cc5540
genehack added a commit that referenced this issue May 21, 2024
@genehack
Fix typo [#9]
bcd96cf
genehack added a commit that referenced this issue May 21, 2024
@genehack
Add pre-commit documentation to README [#9]
3e5825e
genehack added a commit that referenced this issue May 22, 2024
@genehack
Add pre-commit GitHub Action [#9]
da81c45 
Keeping things self-contained to Github Actions seems better than
introducing a dependency on another third-party service, particularly
when the main advantage of that third-party service seems to be
automatically correcting things, which is not a feature I'm interested
in — this is intended only as a compliance check.
genehack added a commit that referenced this issue May 23, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
387e0f5
genehack added a commit that referenced this issue May 23, 2024
@genehack
Remove execute bit from non-executable files [#9]
166c511
genehack added a commit that referenced this issue May 23, 2024
@genehack
Fix typo [#9]
d0ff13c
genehack added a commit that referenced this issue May 23, 2024
@genehack
Add pre-commit documentation to README [#9]
7cceda5
genehack added a commit that referenced this issue May 23, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
ea0dd9f
genehack added a commit that referenced this issue May 24, 2024
@genehack
Add pre-commit GitHub Action [#9]
d884687 
Keeping things self-contained to Github Actions seems better than
introducing a dependency on another third-party service, particularly
when the main advantage of that third-party service seems to be
automatically correcting things, which is not a feature I'm interested
in — this is intended only as a compliance check.
genehack added a commit that referenced this issue May 24, 2024
@genehack
Add pre-commit GitHub Action [#9]
3ff2fc4 
Keeping things self-contained to Github Actions seems better than
introducing a dependency on another third-party service, particularly
when the main advantage of that third-party service seems to be
automatically correcting things, which is not a feature I'm interested
in — this is intended only as a compliance check.
genehack added a commit that referenced this issue May 24, 2024
@genehack
remove yamlfmt from pre-commit [#9]
1d7e12b
genehack added a commit that referenced this issue May 24, 2024
@genehack
Add pre-commit GitHub Action [#9]
3d9c35f 
Keeping things self-contained to Github Actions seems better than
introducing a dependency on another third-party service, particularly
when the main advantage of that third-party service seems to be
automatically correcting things, which is not a feature I'm interested
in — this is intended only as a compliance check.
genehack added a commit that referenced this issue May 24, 2024
@genehack
remove yamlfmt from pre-commit [#9]
86df70f
genehack added a commit that referenced this issue May 24, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
03af4d9
genehack added a commit that referenced this issue May 29, 2024
@genehack
Strip down pre-commit config [#9]
3e66f86 
* remove snakefmt
* remove yamlfmt
* remove codespell
* remove toml-sort
* remove associated configuration

All of these are things that are potentially "auto-formatting" code.
genehack added a commit that referenced this issue May 29, 2024
@genehack
Strip down pre-commit config [#9]
c5946b4 
* remove snakefmt
* remove yamlfmt
* remove codespell
* remove toml-sort
* remove associated configuration

All of these are things that are potentially "auto-formatting" code.
@genehack genehack mentioned this issue May 29, 2024
Closed
genehack added a commit that referenced this issue May 29, 2024
@genehack
Whitespace cleanup from pre-commit [#9]
72ebaab
@genehack genehack mentioned this issue May 29, 2024
Closed
@genehack genehack closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genehack genehack

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@genehack