-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thunderbird: support setting search engines #5697
thunderbird: support setting search engines #5697
Conversation
0cbe471
to
85bcdc2
Compare
85bcdc2
to
10b321f
Compare
I also just pushed a change that also organizes the firefox tests by submodule. |
10b321f
to
7dbd977
Compare
Actually, I just decided to split off test refactoring into it's own PR, because the change is easier to review separately: #5698 |
8ff99b4
to
b646398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kira-bruneau! No issues from my side, since it doesn't affect the functionality of the Firefox module. The formatting only conflicts with #5685 so far, which would become your responsibility when you become the maintainer of this module.
enable = mkOption { | ||
type = with types; bool; | ||
default = config.default != null || config.privateDefault != null | ||
|| config.order != [ ] || config.engines != { }; | ||
internal = true; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this internal enable
option to make the implicit enable behaviour reusable, but I think ideally users should be required to set enable
explicitly. I just didn't want to introduce any breaking changes here.
I plan on folding the force
option into enable
in a follow-up PR.
Split off from #5697, organizes firefox tests by submodule. This is intended to match directory structure setup for the new search submodule.
Split off from nix-community#5697, organizes firefox tests by submodule. This is intended to match directory structure setup for the new search submodule.
67b1242
to
d58208f
Compare
Getting this after this commit. Both files referenced with different definitions are the firefox module in home-manager. error: The option `home-manager.users.khaneliman.home.file.".mozilla/firefox/khaneliman/search.json.mozlz4".enable' has conflicting definition values:
- In `/nix/store/i9vkk0yd40vsvn73a1rfi60p2p0dhc8m-source/modules/programs/firefox.nix': true
- In `/nix/store/i9vkk0yd40vsvn73a1rfi60p2p0dhc8m-source/modules/programs/firefox.nix': false |
before merging, I managed to rebuild firefox with custom search engines and started thunderbird (that I dont use ) fine hence the merge. I apaprently missed some stuff. |
Hmm.. I can double check my config.. but I didn't spend too much time looking originally because both files referenced were an internal home-manager module. |
Appears to be issue with multiple profiles sharing a path. One profile doesn't set the search option, the other uses it. This conflict is thrown. profiles = {
"dev-edition-default" = {
id = 0;
path = "${config.${namespace}.user.name}";
};
${config.${namespace}.user.name} = {
inherit (cfg) extraConfig extensions search;
inherit (config.${namespace}.user) name; |
Description
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Submodule already tested in
firefox-profile-search
tests.Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
Firefox:
@rycee @brckd
Thunderbird:
@d-dervishi