Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: organize tests by submodule #5698

Merged

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Aug 1, 2024

Description

Split off from #5697, organizes firefox tests by submodule.

This is intended to match directory structure setup for the new search submodule.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee @brckd

@kira-bruneau kira-bruneau force-pushed the firefox-organize-tests-by-submodule branch from aa24835 to 8ff99b4 Compare August 1, 2024 19:56
@github-actions github-actions bot added the mail label Aug 1, 2024
@kira-bruneau kira-bruneau force-pushed the firefox-organize-tests-by-submodule branch from 8ff99b4 to 6cd92b9 Compare August 1, 2024 19:58
@github-actions github-actions bot removed the mail label Aug 1, 2024
Copy link
Contributor

@brckd brckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This doesn't seem to create merge conflicts as of yet.

Just note that firefox/firefox.nix was named like that so that other derivatives could be added to e.g. firefox/librewolf.nix. Changing it to firefox/default.nix suggests to add tests for other derivatives to e.g. librewolf/default.nix. I'm indifferent to this change.

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Aug 2, 2024

Oh ok sorry! I didn't realize that was a recent change. I just noticed it seemed out of place compared to all the other tests. I'll change it back!

@kira-bruneau kira-bruneau force-pushed the firefox-organize-tests-by-submodule branch from 6cd92b9 to 75c0805 Compare August 2, 2024 17:23
@kira-bruneau kira-bruneau force-pushed the firefox-organize-tests-by-submodule branch 2 times, most recently from fe98bae to 681e848 Compare October 2, 2024 16:59
@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Oct 2, 2024

I tried rebasing in fe98bae to fix the macos-latest tests, but now ubuntu-latest is failing for an unrelated reason: NixOS/nixpkgs#345965.

I'll try again once that's been resolved.

@kira-bruneau kira-bruneau force-pushed the firefox-organize-tests-by-submodule branch from 681e848 to 384774f Compare October 5, 2024 13:55
@teto
Copy link
Collaborator

teto commented Oct 7, 2024

I am oblivious to the change but firefox maintainer approves so lets' merge

@teto teto merged commit 271c83e into nix-community:master Oct 7, 2024
3 checks passed
Mikilio pushed a commit to Mikilio/home-manager that referenced this pull request Oct 11, 2024
Split off from nix-community#5697, organizes firefox tests by submodule.

This is intended to match directory structure setup for the new search submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants