-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox: organize tests by submodule #5698
firefox: organize tests by submodule #5698
Conversation
aa24835
to
8ff99b4
Compare
8ff99b4
to
6cd92b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This doesn't seem to create merge conflicts as of yet.
Just note that firefox/firefox.nix
was named like that so that other derivatives could be added to e.g. firefox/librewolf.nix
. Changing it to firefox/default.nix
suggests to add tests for other derivatives to e.g. librewolf/default.nix
. I'm indifferent to this change.
Oh ok sorry! I didn't realize that was a recent change. I just noticed it seemed out of place compared to all the other tests. I'll change it back! |
6cd92b9
to
75c0805
Compare
fe98bae
to
681e848
Compare
I tried rebasing in fe98bae to fix the macos-latest tests, but now ubuntu-latest is failing for an unrelated reason: NixOS/nixpkgs#345965. I'll try again once that's been resolved. |
681e848
to
384774f
Compare
I am oblivious to the change but firefox maintainer approves so lets' merge |
Split off from nix-community#5697, organizes firefox tests by submodule. This is intended to match directory structure setup for the new search submodule.
Description
Split off from #5697, organizes firefox tests by submodule.
This is intended to match directory structure setup for the new search submodule.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@rycee @brckd