Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add full Python 3 tests to Travis CI #29360

Closed
wants to merge 4 commits into from
Closed

build: add full Python 3 tests to Travis CI #29360

wants to merge 4 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 28, 2019 •
edited
Loading

This PR significantly reduces our Travis CI build times and provides better test coverage.

Remove the former, incomplete Travis CI runs on Python 3.6 and 3.7 and replace them with the full 5 stage pipeline running on both Python 2.7 and 3.6.

The Python 3.6 tests pass all runs except Test C++ Suites (py3) as discussed in #29246 and the Python 3.6 run can be replaced with a Python 3.7 run when #29346 or similar has landed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 28, 2019
@cclauss cclauss changed the title Add py3 to travis ci build: add full Python 3 tests to Travis CI Aug 28, 2019
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Aug 28, 2019
@cclauss cclauss requested a review from Trott August 28, 2019 23:02
bnoordhuis
bnoordhuis approved these changes Aug 29, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
targos
targos reviewed Aug 29, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor Author

cclauss commented Aug 29, 2019

Does the output of Compile V8 (py2) overwrite the output of Compile V8 (py3) (or vise-versa)?

@bnoordhuis
Copy link
Member

Does the output of Compile V8 (py2) overwrite the output of Compile V8 (py3) (or vise-versa)?

No? Or is that a trick question? :-)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25306/

Trott
Trott reviewed Sep 1, 2019
View reviewed changes
.travis.yml
addons:
apt:
update: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the update: true lines should be there in the final result or should that last commit (that adds them) be omitted when landing? I'm guessing they should be there but I'm asking anyway because the commit message suggests it might be temporary--"Force a retest"--and the Travis docs mildly discourage its use.

Copy link
Contributor Author

@cclauss cclauss Sep 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they can stay in. I believe that the Travis docs are discouraging upgrade vs. update.

Trott pushed a commit to Trott/io.js that referenced this pull request Sep 1, 2019
@cclauss @Trott
build: add full Python 3 tests to Travis CI
c602b0a 
PR-URL: nodejs#29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 1, 2019

Landed in c602b0a

@Trott Trott closed this Sep 1, 2019
@cclauss cclauss deleted the add-py3-to-travis-ci branch September 1, 2019 19:27
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 2, 2019
@bnoordhuis
Revert "build: add full Python 3 tests to Travis CI"
e46b9e9 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360
@bnoordhuis bnoordhuis mentioned this pull request Sep 2, 2019
Closed
Trott pushed a commit to Trott/io.js that referenced this pull request Sep 3, 2019
@bnoordhuis @Trott
Revert "build: add full Python 3 tests to Travis CI"
cd2a3f8 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360

PR-URL: nodejs#29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@cclauss @BridgeAR
build: add full Python 3 tests to Travis CI
8f6b852 
PR-URL: #29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@bnoordhuis @BridgeAR
Revert "build: add full Python 3 tests to Travis CI"
e6aca32 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@cclauss @BridgeAR
build: add full Python 3 tests to Travis CI
256da1f 
PR-URL: #29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@bnoordhuis @BridgeAR
Revert "build: add full Python 3 tests to Travis CI"
449f1fd 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced Sep 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@targos targos targos left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@devnexen devnexen devnexen approved these changes

@richardlau richardlau richardlau approved these changes

@rvagg rvagg Awaiting requested review from rvagg

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@mhdawson mhdawson Awaiting requested review from mhdawson

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cclauss @bnoordhuis @nodejs-github-bot @Trott @targos @devnexen @richardlau