Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add full Python 3 tests to Travis CI #29360

Closed
wants to merge 4 commits into from
Closed

build: add full Python 3 tests to Travis CI #29360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
736ec33
build: add full Python 3 tests to Travis CI
cclauss Aug 28, 2019
431baf0
Remove paste error
cclauss Aug 28, 2019
a1dd1aa
Set up cache at a global scope
cclauss Aug 29, 2019
9bdf8bc
Force a retest
cclauss Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Force a retest
  • Loading branch information
@cclauss
cclauss committed Aug 29, 2019
commit 9bdf8bcef7b4c8aef1a7bf666edf0bc19f0c6358
4 changes: 4 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
name: "Compile V8 (py2)"
addons:
apt:
update: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the update: true lines should be there in the final result or should that last commit (that adds them) be omitted when landing? I'm guessing they should be there but I'm asking anyway because the commit message suggests it might be temporary--"Force a retest"--and the Travis docs mildly discourage its use.

Copy link
Contributor Author

@cclauss cclauss Sep 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they can stay in. I believe that the Travis docs are discouraging upgrade vs. update.

sources:
- ubuntu-toolchain-r-test
packages:
Expand All @@ -36,6 +37,7 @@ jobs:
- name: "Compile V8 (py3)"
addons:
apt:
update: true
sources:
- ubuntu-toolchain-r-test
packages:
Expand All @@ -50,6 +52,7 @@ jobs:
- name: "Compile Node.js (py2)"
addons:
apt:
update: true
sources:
- ubuntu-toolchain-r-test
packages:
Expand All @@ -65,6 +68,7 @@ jobs:
- name: "Compile Node.js (py3)"
addons:
apt:
update: true
sources:
- ubuntu-toolchain-r-test
packages:
Expand Down