Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.5.0 release proposal #39373

Merged
merged 133 commits into from
Jul 14, 2021
Merged

v16.5.0 release proposal #39373

merged 133 commits into from
Jul 14, 2021

Conversation

targos
Copy link
Member

@targos targos commented Jul 13, 2021

2021-07-14, Version 16.5.0 (Current), @targos

Notable Changes

Experimental Web Streams API

Node.js now exposes an experimental implementation of the
Web Streams API.

While it is experimental, the API is not exposed on the global object and is only
accessible using the new stream/web core module:

import { ReadableStream, WritableStream } from 'stream/web'; // Or 'node:stream/web'

Importing the module will emit a single experimental warning per process.

The raw API is implemented and we are now working on its integration with
various existing core APIs.

Contributed by James M Snell - #39062

Other notable changes

Commits

cjihrig and others added 30 commits July 11, 2021 09:43
This commit updates compare_ipv4() to use the host byte
order.

PR-URL: #39096
Fixes: #39074
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Actions interface has a better integration with GitHub, and with
Annotations and Problem Matcher we can display all failed checks in a
single place, so that users don't have to go through the logs to figure
out what's wrong. Since the job on Travis was allowed to fail and is not
as easy to read, remove it from our Matrix.

The Action will check every commit in the Pull Request, skipping commits
with "fixup" or "squash".

PR-URL: #32417
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
The commit linter was checking out the PR HEAD commit instead of
merge/rebase commit, causing it to fail for any PRs that were not
rebased on our default branch. Removing `ref` should fix the issue.

PR-URL: #39121
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #39113
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
V8's test-runner dropped the `--mode` argument some time back, and now
produces the following error if run with it:
  run-tests.py: error: no such option: --mode

PR-URL: #39055
Refs: #35705
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fix the napi_default_jsproperty flag of the napi_property_attributes
enum that was incorrectly referred to as napi_default_property.

Signed-off-by: Davidson Francis <davidsondfgl@gmail.com>

PR-URL: #39104
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
On Windows there is a limit to the length of commands, so there
will be an error once the lengths of the JS file names combined
exceed that limit. This patch modifies js2c.py so that
it now takes a --directory argument to glob for .js and
.mjs files in addition to the list of files passed directly.
We still pass the additional files we include from deps/
directly through the command line, as we only includes some of
them so we cannot simply glob, but those are limited so listing
them out should be fine.

Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation

PR-URL: #39069
Refs: #38971
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39043
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Adding a return when it's not really a getter is kind of misleading, but
so is using a getter for something that doesn't return anything, so
¯\_(ツ)_/¯.

PR-URL: #39078
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #39082
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Fixes: #38883

PR-URL: #38913
Refs: #38883
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Fixes: #38954

PR-URL: #38992
Refs: #30570
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #39091
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The `wasi` lib module's `initialize()` method is missing a validator.

PR-URL: #39070
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
The `fs` lib module's `mkdtemp()` and `mkdtempSync()` methods were
missing a validator, and weren't allowing the empty string as a valid
prefix.

PR-URL: #39028
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
PR-URL: #39170
Refs: nodejs/remark-preset-lint-node#188
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #39105
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- Move Performance and InternalPerformance to a new
  lib/internal/perf/performance.js
- Move now() getMilestoneTimestamp() into
  lib/internal/perf/utils.js
- Rename lib/internal/perf/perf.js to
  lib/internal/perf/performance_entry.js
- Refresh time origin at startup (this means the
  time origins could differ between snapshot building
  time and snapshot creation time)

PR-URL: #38971
Refs: #35711
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38971
Refs: #35711
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38971
Refs: #35711
Reviewed-By: James M Snell <jasnell@gmail.com>
When I moved node-inspect into core, I called a lot of things
`inspector-cli` that really should have been `debugger`. This is the
last of them to be renamed.

PR-URL: #39156
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Stick with "repository" instead of using both "repository" and "repo".

PR-URL: #39157
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Logic in module_job.js assumes detailed stack trace from node_errors.cc
which is not populated when --enable-source-maps is set.

Fixes #38790

PR-URL: #39017
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Refs: nodejs/remark-preset-lint-node#188

PR-URL: #39165
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #39138
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
We can remove the Acorn plugins as their features are now supported
by default.

PR-URL: #39166
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #39148
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs nodejs deleted a comment from nodejs-github-bot Jul 13, 2021
targos added a commit that referenced this pull request Jul 13, 2021
Notable changes:

deps:
  * upgrade npm to 7.19.1 (npm-robot) #39225
fs:
  * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028
stream:
  * (SEMVER-MINOR) implement Web Streams API (James M Snell) #39062

PR-URL: #39373
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2021

@targos
Copy link
Member Author

targos commented Jul 13, 2021

@nodejs/platform-ppc Can you please help about this error: https://ci.nodejs.org/job/node-test-commit-v8-linux/4134/nodes=centos7-ppcle,v8test=v8test/console

@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 13, 2021
@miladfarca
Copy link
Contributor

@richardlau try installing libgtk-3-dev and libglib2.0-dev, it should fix the glib issue.

@richardlau
Copy link
Member

@richardlau try installing libgtk-3-dev and libglib2.0-dev, it should fix the glib issue.

The machines are running centos7 -- the missing package was glib2-devel (nodejs/build#2702 (comment)). I've opened a pull request to automate installing it on the ppc64 machines: nodejs/build#2709

@bricss
Copy link

bricss commented Jul 13, 2021

Isn't it too late to squash this #39134 in? 😃

Notable changes:

deps:
  * upgrade npm to 7.19.1 (npm team) #39225
fs:
  * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028
stream:
  * (SEMVER-MINOR) implement Web Streams API (James M Snell) #39062

PR-URL: #39373
@targos
Copy link
Member Author

targos commented Jul 14, 2021

I updated "npm-robot" to "npm team" in the changelog (npm/cli#3541)

@targos
Copy link
Member Author

targos commented Jul 14, 2021

@targos targos merged commit eaca13d into v16.x Jul 14, 2021
targos added a commit that referenced this pull request Jul 14, 2021
@targos targos deleted the v16.5.0-proposal branch July 14, 2021 09:08
targos added a commit that referenced this pull request Jul 14, 2021
Notable changes:

deps:
  * upgrade npm to 7.19.1 (npm team) #39225
fs:
  * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) #39028
stream:
  * (SEMVER-MINOR) implement Web Streams API (James M Snell) #39062

PR-URL: #39373
targos added a commit to targos/nodejs.org that referenced this pull request Jul 14, 2021
targos added a commit to nodejs/nodejs.org that referenced this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.