chore: use better name on nodejs commits #3541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the name: `npm-robot` is being used in nodejs changelogs as the atttribution author name for npm-update commits. This makes it so that entries in the changelog referring to our updates reads like: ``` upgrade npm to 7.18.1 (npm-robot) #39065 ``` This change makes it so that the name used in commits is `npm team`, this way the changelogs entry should read instead as: ``` upgrade npm to 7.18.1 (npm team) #39065 ``` Ref: https://nodejs.org/en/blog/release/v16.4.0/
|
@ruyadorno You can also add an entry into https://github.com/nodejs/node/blob/master/.mailmap which would remap the existing commits. |
ruyadorno
added
Release 7.x
targos
approved these changes
Jul 14, 2021
BethGriggs
approved these changes
Jul 14, 2021
ruyadorno
added a commit
that referenced
this pull request
Jul 15, 2021
Currently, the name: `npm-robot` is being used in nodejs changelogs as the atttribution author name for npm-update commits. This makes it so that entries in the changelog referring to our updates reads like: ``` upgrade npm to 7.18.1 (npm-robot) #39065 ``` This change makes it so that the name used in commits is `npm team`, this way the changelogs entry should read instead as: ``` upgrade npm to 7.18.1 (npm team) #39065 ``` Ref: https://nodejs.org/en/blog/release/v16.4.0/ PR-URL: #3541 Credit: @ruyadorno Close: #3541 Reviewed-by: @wraithgar, @targos, @BethGriggs
|
Landed in c11aa53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the name:
npm-robotis being used in nodejs changelogs asthe atttribution author name for npm-update commits. This makes it so
that entries in the changelog referring to our updates reads like:
This change makes it so that the name used in commits is
npm team,this way the changelogs entry should read instead as:
References
Example: https://nodejs.org/en/blog/release/v16.4.0/
cc @darcyclarke @gimli01 @targos @richardlau @BethGriggs