Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove dead code in test-http2-misbehaving-multiplex #54860

Merged
merged 2 commits into from
Sep 12, 2024
Merged

test: remove dead code in test-http2-misbehaving-multiplex #54860

merged 2 commits into from
Sep 12, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 9, 2024 •
edited
Loading

As titled.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 9, 2024
lpinca
lpinca commented Sep 9, 2024
View reviewed changes
test/parallel/test-http2-misbehaving-multiplex.js
stream.on('error', () => {});
stream.on('close', (err) => {
if (stream.id === 1) {
if (gotFirstStreamId1) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this branch was taken, the test would fail because there is nothing that calls the function returned by common.expectsError() below.

@RedYetiDev
Copy link
Member

Does this also deflake it?

@RedYetiDev RedYetiDev added the http2 Issues or PRs related to the http2 subsystem. label Sep 9, 2024
@lpinca
Copy link
Member Author

lpinca commented Sep 9, 2024

Does this also deflake it?

No.

@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (e1e312d) to head (b7ef4a2).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54860   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         651      651           
  Lines      183343   183343           
  Branches    35710    35712    +2     
=======================================
+ Hits       161165   161168    +3     
+ Misses      15466    15455   -11     
- Partials     6712     6720    +8

see 27 files with indirect coverage changes

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62235/

@lpinca
Copy link
Member Author

lpinca commented Sep 10, 2024

This could be closed in favor of #54872.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 9db6327 into nodejs:main Sep 12, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9db6327

@lpinca lpinca deleted the remove/dead-code branch September 12, 2024 06:02
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@lpinca @aduh95
test: remove dead code in test-http2-misbehaving-multiplex
0480c64 
PR-URL: #54860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@lpinca @aduh95
test: remove dead code in test-http2-misbehaving-multiplex
e71911f 
PR-URL: #54860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@lpinca @aduh95
test: remove dead code in test-http2-misbehaving-multiplex
b198a91 
PR-URL: #54860
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@trivikr trivikr trivikr approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lpinca @RedYetiDev @nodejs-github-bot @jasnell @anonrig @trivikr @LiviaMedeiros