Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-http2-misbehaving-multiplex #54872

Merged
merged 1 commit into from
Sep 12, 2024
Merged

test: deflake test-http2-misbehaving-multiplex #54872

merged 1 commit into from
Sep 12, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 10, 2024

Fixes: #54859

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 10, 2024
@lpinca lpinca mentioned this pull request Sep 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (9db6327) to head (8460fc4).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54872      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files         651      651              
  Lines      183405   183405              
  Branches    35822    35820       -2     
==========================================
- Hits       161499   161490       -9     
- Misses      15159    15166       +7     
- Partials     6747     6749       +2

see 29 files with indirect coverage changes

@lpinca lpinca force-pushed the deflake/test-http2-misbehaving-multiplex branch from c2546eb to 484e720 Compare September 12, 2024 06:11
@lpinca lpinca force-pushed the deflake/test-http2-misbehaving-multiplex branch from 484e720 to 8460fc4 Compare September 12, 2024 06:19
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62353/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit e60caee into nodejs:main Sep 12, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e60caee

@lpinca lpinca deleted the deflake/test-http2-misbehaving-multiplex branch September 12, 2024 15:50
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@lpinca @RafaelGSS
test: deflake test-http2-misbehaving-multiplex
475498b 
Fixes: #54859
PR-URL: #54872
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@lpinca @RafaelGSS
test: deflake test-http2-misbehaving-multiplex
2efec62 
Fixes: #54859
PR-URL: #54872
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel/test-http2-misbehaving-multiplex is flaky
5 participants
@lpinca @nodejs-github-bot @jasnell @richardlau @jakecastelli