chore: add integration tests to generate_message #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prybalko
commented
Aug 16, 2022
| @@ -1065,14 +1065,16 @@ | |||
| //! | |||
| //! `$ cargo run meta-at-block --url wss://westend-rpc.polkadot.io --block | |||
| //! 780812df50c4006d1865742269fe4ca339c097e61d6279cce91ebc58f5aebada` | |||
| #![deny(unused_crate_dependencies)] | |||
| #![deny(unused)] | |||
There was a problem hiding this comment.
There is a false-positive using unused_crate_dependencies rust-lang/rust#72686
montekki
reviewed
Aug 16, 2022
montekki
reviewed
Aug 18, 2022
montekki
reviewed
Aug 19, 2022
montekki
approved these changes
Aug 22, 2022
|
|
||
| #[test] | ||
| fn it_derives() { | ||
| let files_dir = PathBuf::from("./tests/it_derives"); |
There was a problem hiding this comment.
What I meant was rather something like tempdir::Tempdir::new("it_derives") which would be more convenient and deleted when it goes out of scope so it wouldn't be necessary to do the teardown in the end.
|
|
||
| #[test] | ||
| fn it_unwasm() { | ||
| let files_dir = PathBuf::from("./tests/it_unwasm"); |
There was a problem hiding this comment.
probably should make all these relative variables as absolute with env!(CARGO_MANIFEST_DIR).push("./tests/it_unwasm") but I cannot really come up with a counterexample to the relative dir off the top of my head.
krodak
added a commit
that referenced
this pull request
Aug 24, 2022
* master: chore: add derived_keys_count to SeedNameCard (#1235) ci: pin gha versions (#1232) chore: fix build issues and Preview Content (#1234) chore: Revert "chore: fix build issues and Preview Content" (#1233) chore: fix build issues and Preview Content chore: scale identicons (#1230) chore: add integration tests to generate_message (#1219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integrations tests for
generate_messageCLI that doesn't do RPC calls