chore: fix build issues and Preview Content #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prybalko
approved these changes
Aug 24, 2022
montekki
approved these changes
Aug 24, 2022
krodak
added a commit
that referenced
this pull request
Aug 24, 2022
* master: chore: add derived_keys_count to SeedNameCard (#1235) ci: pin gha versions (#1232) chore: fix build issues and Preview Content (#1234) chore: Revert "chore: fix build issues and Preview Content" (#1233) chore: fix build issues and Preview Content chore: scale identicons (#1230) chore: add integration tests to generate_message (#1219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes issues with SwiftUI "Preview Content" mode that enables easy UI prototyping and also some build issues that started happening after changing the branch or multiple builds, after changes introduced by: #1229
Scope
TODOs
Opened issue: [Documentation] Improve documentation for Xcode integration to help solve runtime issues mozilla/uniffi-rs#1315
Discussion
This is XCode 13+ related issue, found solution while googling this out on one of the issues within Cuckoo Github page (tool that autogenerates files for Swift)
Screenshots
Properly not generating files when indexing
Previews working