fix: handle symlinking when root directory begins with a special char… #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonochromeChameleon
force-pushed
the
latest
branch
from
ec22ce8
to
4cdccec
Compare
|
Thanks! This will be in the next npm release. |
isaacs
added a commit
that referenced
this pull request
Jun 15, 2021
The change made in e8c4301 (#53) was reasonable, but had the unfortunate side effect of breaking backwards compatibility for urls like 'file://.'. Further investigation showed that we really weren't complying with RFC 8909's specifications regarding file: URLs, and even further investigation than that showed that it'll be a breaking change if we do. This patch isolates the non-8909 compliance bits into a single block that can be disabled with an environment variable and easily removed when we are willing to take on that breaking change. The bug fixed by the commit that broke file://. is still fixed, and we obey RFC8909 otherwise.
isaacs
added a commit
that referenced
this pull request
Jun 15, 2021
The change made in e8c4301 (#53) was reasonable, but had the unfortunate side effect of breaking backwards compatibility for urls like 'file://.'. Further investigation showed that we really weren't complying with RFC 8909's specifications regarding file: URLs, and even further investigation than that showed that it'll be a breaking change if we do. This patch isolates the non-8909 compliance bits into a single block that can be disabled with an environment variable and easily removed when we are willing to take on that breaking change. The bug fixed by the commit that broke file://. is still fixed, and we obey RFC8909 otherwise. PR-URL: #60 Credit: @isaacs Close: #60 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This arose out of my investigation into npm/cli#2447
The file resolution for local paths beginning with
/~somethingor/.somethingstrips off the leading slash, meaning that the eventual resolved path is incorrect as it is incorrectly treated as not being an absolute pathI've added a couple of test cases to demonstrate the failing situations and altered the regexp replacement to only match
~and.characters that are followed by a/References
Related to npm/cli#2447