Make file: URLs (mostly) RFC 8909 compliant #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arguably beneficial side effect of this change: |
isaacs
force-pushed
the
isaacs/rfc-8909-compliant
branch
2 times, most recently
from
92132b3
to
97d2923
Compare
ruyadorno
reviewed
Jun 15, 2021
| res.saveSpec = 'file:' + path.relative(where, res.fetchSpec) | ||
| // always put the '/' on where when resolving urls, or else | ||
| // file:foo from /path/to/bar goes to /path/to/foo, when we want | ||
| // it to be /path/to/foo/bar |
There was a problem hiding this comment.
if using file:foo from /path/to/bar, wouldn't we want it to be /path/to/bar/foo instead?
There was a problem hiding this comment.
Yes, that's what the comment is saying.
There was a problem hiding this comment.
hahaha no, it says /path/to/foo/bar
There was a problem hiding this comment.
oh, haha, yeah, swapped the parts in the comment. The code is right, though. I'll fix it.
The change made in e8c4301 (#53) was reasonable, but had the unfortunate side effect of breaking backwards compatibility for urls like 'file://.'. Further investigation showed that we really weren't complying with RFC 8909's specifications regarding file: URLs, and even further investigation than that showed that it'll be a breaking change if we do. This patch isolates the non-8909 compliance bits into a single block that can be disabled with an environment variable and easily removed when we are willing to take on that breaking change. The bug fixed by the commit that broke file://. is still fixed, and we obey RFC8909 otherwise. PR-URL: #60 Credit: @isaacs Close: #60 Reviewed-by: @ruyadorno
isaacs
force-pushed
the
isaacs/rfc-8909-compliant
branch
from
97d2923
to
8a6d887
Compare
ruyadorno
added a commit
to ruyadorno/npm-package-arg
that referenced
this pull request
Jun 15, 2021
Relates to: npm#60 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made in e8c4301 was
reasonable, but had the unfortunate side effect of breaking backwards
compatibility for urls like 'file://.'.
Further investigation showed that we really weren't complying with RFC
8909's specifications regarding file: URLs, and even further
investigation than that showed that it'll be a breaking change if we do.
This patch isolates the non-8909 compliance bits into a single block
that can be disabled with an environment variable and easily removed
when we are willing to take on that breaking change. The bug fixed by
the commit that broke file://. is still fixed, and we obey RFC8909
otherwise.
References