Nuphy air75 cleanup #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting the commits that modified this would be preferable, but merge commits make that an ugly process
Also rename all tables to `_tab` for consistency
Conform with the QMK C coding conventions: https://docs.qmk.fm/coding_conventions_c
|
If you don't want to include the LED functionality changes in this PR I can drop them, but I think they're worthwhile, and relatively trivial code-wise, so would be nice to see them in the official release. |
Revert "Remove function" This reverts commit 861b3fc. revert commit remove function
|
Thank you for your suggestions. I will continue to monitor this issue and respond promptly. |
nuphy-src
force-pushed
the
nuphy-air75
branch
4 times, most recently
from
7911e20
to
a4f5754
Compare
|
Is this going to be merged? It'd be good to update master to the latest upstream code and try to merge NuPhy support into the official QMK repository! |
|
Unfortunately it looks like rather than merge this PR, Nuphy decided to commit their own subset of these changes, in addition to a bunch of other stuff, so there are now a lot of conflicts and I'd say it's unlikely that the changes in this PR will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up various style and spelling issues, as reviewed by a number of parties at:
qmk#22751
In addition, the following enhancements are provided:
Types of Changes
Issues Referenced by This PR
Checklist