[Keyboard] Add nuphy air75 v2 keyboard #22751

nuphy-src · 2023-12-25T14:29:41Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dunk2k

Add Community Layout support

keyboards/nuphy/air75_v2/ansi/info.json

keyboards/nuphy/air75_v2/ansi/keymaps/default/keymap.c

keyboards/nuphy/air75_v2/ansi/keymaps/via/keymap.c

keyboards/nuphy/air75_v2/ansi/ansi.c

keyboards/nuphy/air75_v2/ansi/keymaps/default/keymap.c

keyboards/nuphy/air75_v2/ansi/keymaps/via/keymap.c

keyboards/nuphy/air75_v2/ansi/side_driver.c

keyboards/nuphy/air75_v2/ansi/config.h

keyboards/nuphy/air75_v2/ansi/info.json

… into nuphy-air75

RDhar · 2024-01-02T12:10:31Z

Hi @nuphy-src, if you wouldn't mind, could you please resolve/comment on @adophoxia, @dunk2k and @drashna's (code) suggestions so it's easier to follow progress on this PR?

… into nuphy-air75

nuphy-src · 2024-01-07T16:56:10Z

Hello everyone, @dunk2k @RDhar @drashna @adophoxia ,I have adjusted the code according to your suggestions, please kindly approve the modified content, thank you

nuphy-src · 2024-01-07T17:00:02Z

Hi @nuphy-src, if you wouldn't mind, could you please resolve/comment on @adophoxia, @dunk2k and @drashna's (code) suggestions so it's easier to follow progress on this PR?

Hi rdhar, I have adjusted the code according to your suggestions. please kindly approve the modified content, thank you

jincao1 · 2024-01-07T17:49:46Z

@nuphy-src In your latest commit the key codes for KC_LGUI, KC_LALT and KC_RGUI are in the wrong place in the windows layer. It was previously correct but looks like you made them match the Mac layer. The Mac layer is corrected with the wrong key placements before but in the process you broke the Windows layer. FYI.

nuphy-src · 2024-01-07T17:56:02Z

@nuphy-src In your latest commit the key codes for KC_LGUI, KC_LALT and KC_RGUI are in the wrong place in the windows layer. It was previously correct but looks like you made them match the Mac layer. The Mac layer is corrected with the wrong key placements before but in the process you broke the Windows layer. FYI.

Thanks for your reminding, I will correct this problem immediately

DP19 · 2024-01-07T18:05:14Z

@nuphy-src FYI a few others and I have built and run this version of the firmware and the media controls don't work in wireless modes in its current form.

We've made various changes to get it working but none of us are super well versed in C /qmk so there may be better ways to fix it

nuphy-src · 2024-01-07T18:10:44Z

@nuphy-src FYI a few others and I have built and run this version of the firmware and the media controls don't work in wireless modes in its current form.

We've made various changes to get it working but none of us are super well versed in C /qmk so there may be better ways to fix it

May I ask which key does not function? KC_MCTL?

DP19 · 2024-01-07T18:14:13Z

@nuphy-src FYI a few others and I have built and run this version of the firmware and the media controls don't work in wireless modes in its current form.

We've made various changes to get it working but none of us are super well versed in C /qmk so there may be better ways to fix it

May I ask which key does not function? KC_MCTL?

IIRC it's everything in the function row that begin with KC_

At least on MAC. @jincao1 can probably speak to Windows

nuphy-src · 2024-01-07T18:19:36Z

@nuphy-src FYI a few others and I have built and run this version of the firmware and the media controls don't work in wireless modes in its current form.

We've made various changes to get it working but none of us are super well versed in C /qmk so there may be better ways to fix it

May I ask which key does not function? KC_MCTL?

IIRC it's everything in the function row that begin with KC_

At least on MAC. @jincao1 can probably speak to Windows

About the problem: The multimedia button does not function in mac system. I'll test the side again later. Thank you

RDhar · 2024-01-07T18:21:03Z

As @DP19 mentioned, here's collection of ongoing QMK firmware forks for Nuphy keyboards maintained by @zhogov.

It might be worth accepting input at this early stage from positively-active contributors like @jincao1 and @edykim. Really embracing the open-source culture to share the best of community development.

These contributors and more are already present on your Discord's Custom firmware on Air75v2 channel, if you'd like to continue the conversation there.

nuphy-src · 2024-01-07T18:24:03Z

As @DP19 mentioned, here's collection of ongoing QMK firmware forks for Nuphy keyboards maintained by @zhogov.

It might be worth accepting input at this early stage from positively-active contributors like @jincao1 and @edykim. Really embracing the open-source culture to share the best of community development.

These contributors and more are already present on your Discord's Custom firmware on Air75v2 channel, if you'd like to continue the conversation there.

Yes, I am also happy to share my code here, and welcome your suggestions, Thanks

jincao1 · 2024-01-07T18:54:36Z

I believe the issue with the F modifiers are that none of them work in RF because the current implementation with core QMK does not send the system and consumer reports when in RF mode.

I wrote a simple RF driver to handle that within the QMK lifecycle. Keep in mind I'm not a C developer.

Feel free to look at these commits I made in the diff below relating to the RF driver and attempts at addressing keys that may get stuck/lost in RF mode.

jincao1/qmk_firmware@2553cb6...faff038

You're welcome to build my branch to test and to cherry pick my changes in. I won't be submitting any PRs as the commits contain customization's I want which your users may not want.

nuphy-src · 2024-01-08T03:09:50Z

I believe the issue with the F modifiers are that none of them work in RF because the current implementation with core QMK does not send the system and consumer reports when in RF mode.

I wrote a simple RF driver to handle that within the QMK lifecycle. Keep in mind I'm not a C developer.

Feel free to look at these commits I made in the diff below relating to the RF driver and attempts at addressing keys that may get stuck/lost in RF mode.

jincao1/qmk_firmware@2553cb6...faff038

You're welcome to build my branch to test and to cherry pick my changes in. I won't be submitting any PRs as the commits contain customization's I want which your users may not want.

Hi Thank you very much for your suggestions and code, your code is of great help to me, I will refer to it to modify my code.

nuphy-src · 2024-01-08T15:30:55Z

Thank you very much for your suggestion @DP19 @jincao1 @RDhar ,and I have modified my code with reference to your code, @jincao1 which is very helpful for me to solve this problem. Thanks

pdf · 2024-06-14T10:33:10Z

keyboards/nuphy/air75_v2/ansi/kb_util.h

+    uint8_t rf_state;
+    uint8_t rf_charge;
+    uint8_t rf_led;
+    uint8_t rf_baterry;


Spelling s/baterry/battery/

I had previously suggested this same fix in this 2024-04-26 comment. However, for some reason, @nuphy-src marked that thread as resolved without fixing it. I just posted this comment asking them to unresolve my 16 unaddressed comments.

np, I'll leave this here until your previous (much more comprehensive) review is reinstated, so that it's clear there's still work to be done.

In the interests of moving this forward, I've submitted a PR against the @nuphy-src branch that fixes all the spelling errors etc that I could find, and fixes the style conventions.

update update update reset submodule

[Keyboard] Add nuphy air75 v2 keyboard

3995b36

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 25, 2023

Merge branch 'master' into nuphy-air75

3bcceb8

dunk2k suggested changes Dec 25, 2023

View reviewed changes

keyboards/nuphy/air75_v2/ansi/info.json Outdated Show resolved Hide resolved

keyboards/nuphy/air75_v2/ansi/keymaps/default/keymap.c Outdated Show resolved Hide resolved

keyboards/nuphy/air75_v2/ansi/keymaps/via/keymap.c Outdated Show resolved Hide resolved

drashna requested changes Dec 26, 2023

View reviewed changes

adophoxia suggested changes Dec 26, 2023

View reviewed changes

keyboards/nuphy/air75_v2/ansi/config.h Outdated Show resolved Hide resolved

keyboards/nuphy/air75_v2/ansi/info.json Show resolved Hide resolved

nuphy-src and others added 3 commits December 28, 2023 01:03

Fixed some issues as suggested

f4495d4

Merge branch 'nuphy-air75' of https://github.com/nuphy-src/qmk_firmware…

f5f1262

… into nuphy-air75

Merge branch 'master' into nuphy-air75

8c1c967

nuphy-src added 2 commits January 8, 2024 00:50

[Keyboard] Adjusted the code format

7642708

Merge branch 'nuphy-air75' of https://github.com/nuphy-src/qmk_firmware…

9e0eb67

… into nuphy-air75

Merge branch 'master' into nuphy-air75

1b27fec

Fix mac layer erroe.

1eb1205

Solved the problem of not sending codes in RF mode

dbab794

pdf reviewed Jun 14, 2024

View reviewed changes

pdf mentioned this pull request Jun 16, 2024

Nuphy air75 cleanup nuphy-src/qmk_firmware#7

Open

14 tasks

nuphy-src force-pushed the nuphy-air75 branch from 036e5ae to d80ce05 Compare July 2, 2024 08:12

github-actions bot added core documentation python cli qmk cli command labels Jul 2, 2024

Merge remote-tracking branch 'upstream/master' into nuphy-air75

00bc5af

nuphy-src force-pushed the nuphy-air75 branch from d80ce05 to ae7a28f Compare July 2, 2024 10:29

github-actions bot removed core documentation python cli qmk cli command labels Jul 2, 2024

nuphy-src force-pushed the nuphy-air75 branch 2 times, most recently from ae0511c to d49e050 Compare July 2, 2024 11:36

github-actions bot added core documentation translation CI dd Data Driven Changes dependencies and removed dependencies core documentation translation CI dd Data Driven Changes labels Jul 2, 2024

update

a4f5754

update update update reset submodule

nuphy-src force-pushed the nuphy-air75 branch from 7911e20 to a4f5754 Compare July 3, 2024 01:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add nuphy air75 v2 keyboard #22751

[Keyboard] Add nuphy air75 v2 keyboard #22751

nuphy-src commented Dec 25, 2023 •

edited

Loading

dunk2k left a comment

RDhar commented Jan 2, 2024 •

edited

Loading

nuphy-src commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

jincao1 commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

DP19 commented Jan 7, 2024 •

edited

Loading

nuphy-src commented Jan 7, 2024

DP19 commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

RDhar commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

jincao1 commented Jan 7, 2024 •

edited

Loading

nuphy-src commented Jan 8, 2024

nuphy-src commented Jan 8, 2024

pdf Jun 14, 2024

roryokane Jun 15, 2024

pdf Jun 15, 2024

pdf Jun 16, 2024

[Keyboard] Add nuphy air75 v2 keyboard #22751

Are you sure you want to change the base?

[Keyboard] Add nuphy air75 v2 keyboard #22751

Conversation

nuphy-src commented Dec 25, 2023 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

dunk2k left a comment

Choose a reason for hiding this comment

RDhar commented Jan 2, 2024 • edited Loading

nuphy-src commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

jincao1 commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

DP19 commented Jan 7, 2024 • edited Loading

nuphy-src commented Jan 7, 2024

DP19 commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

RDhar commented Jan 7, 2024

nuphy-src commented Jan 7, 2024

jincao1 commented Jan 7, 2024 • edited Loading

nuphy-src commented Jan 8, 2024

nuphy-src commented Jan 8, 2024

pdf Jun 14, 2024

Choose a reason for hiding this comment

roryokane Jun 15, 2024

Choose a reason for hiding this comment

pdf Jun 15, 2024

Choose a reason for hiding this comment

pdf Jun 16, 2024

Choose a reason for hiding this comment

nuphy-src commented Dec 25, 2023 •

edited

Loading

RDhar commented Jan 2, 2024 •

edited

Loading

DP19 commented Jan 7, 2024 •

edited

Loading

jincao1 commented Jan 7, 2024 •

edited

Loading