Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inhibit upgrade with SCA enabled manifest #615

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Do not inhibit upgrade with SCA enabled manifest #615

merged 1 commit into from
Jan 13, 2021

Conversation

Rezney
Copy link
Member

@Rezney Rezney commented Nov 9, 2020

@Rezney Rezney added the WIP Work In Progress label Nov 9, 2020
@leapp-bot
Copy link
Collaborator

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the
Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

pirat89
pirat89 reviewed Nov 9, 2020
View reviewed changes
repos/system_upgrade/el7toel8/models/rhsminfo.py Outdated
@@ -18,3 +18,5 @@ class RHSMInfo(Model):
""" Repositories that are enabled on the current system through the subscription-manager. """
existing_product_certificates = fields.List(fields.String(), default=[])
""" Product certificates that are currently installed on the system. """
status = fields.String(default='')
""" RHSM status output. """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mreznik wouldn't be better in this case just boolean field like is_sca? or it seems it could be even generic "mode" and haviing choices CAM and SCA. But mdoe could be confusing a little bit for someone, so is_sca / sca_detected / ... seems to be a better solution. As it is clearly providing info usable by other actors, without need of additional output_parsing in other actors in future (if any actor need it in future).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirat89 changed...

@Rezney Rezney changed the title WIP: Do not inhibit upgrade with SCA enabled manifest Do not inhibit upgrade with SCA enabled manifest Nov 20, 2020
@Rezney
Copy link
Member Author

Rezney commented Nov 27, 2020

Re-tested and seems to be working fine.

@Rezney Rezney removed the WIP Work In Progress label Nov 27, 2020
@Rezney
Copy link
Member Author

Rezney commented Dec 9, 2020

e2e tests

pirat89
pirat89 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected. Waiting for verification by qe

@pirat89 pirat89 added the enhancement New feature or request label Jan 12, 2021
@pirat89
Copy link
Member

pirat89 commented Jan 13, 2021

Verified by RHSM QE.

@pirat89 pirat89 merged commit 745bf10 into oamg:master Jan 13, 2021
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 2, 2021
@drehak
WIP: Release 0.13.0
9e57390 
## Upgrade handling
### Fixes
- Do not inhibit upgrade with SCA enabled manifest (oamg#615)
- Fix false positive on some comments in /etc/default/grub (oamg#587)
- Fix automated ipa-server removal (oamg#617)
- Fix error at /boot/efi existing on non-EFI systems (oamg#627)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- persistentnetnamesconfig: Fix crash on non-existent interface (oamg#625)

### Enhancements
- Add a possibility to overwrite virtualenv name through environment variables (oamg#613)
- Update product certificates (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 2, 2021
@drehak
WIPWIPWIP: Release 0.13.0
1ff6b24 
## Upgrade handling
### Fixes
- Do not inhibit upgrade with SCA enabled manifest (oamg#615)
- Fix false positive on some comments in /etc/default/grub (oamg#587)
- Fix automated ipa-server removal (oamg#617)
- Fix error at /boot/efi existing on non-EFI systems (oamg#627)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- persistentnetnamesconfig: Fix crash on non-existent interface (oamg#625)

### Enhancements
- Add a possibility to overwrite virtualenv name through environment variables (oamg#613)
- Update product certificates (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Tue Feb 2 15:57:58 2021 +0100
#
# On branch release/202102
# Your branch is up to date with 'drehak/release/202102'.
#
# No changes
@drehak drehak mentioned this pull request Feb 2, 2021
Merged
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 4, 2021
@drehak
Release 0.13.0
bdcdddb 
## Packaging
- Bump required leapp-framework capability to 1.4 (oamg#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (oamg#600)
- Fix remediation command for ipa-server removal (oamg#617)
- Fix crash due to missing network interfaces during upgrade phases (oamg#625)
- Fix error with /boot/efi existing on non-EFI systems (oamg#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (oamg#503)
- Allow upgrade with SCA enabled manifest (oamg#615)
- Add actors to migrate Quagga to FRR (oamg#467)
- Add stable uniq Key id for every dialog (oamg#618)
- Respect the *kernel-rt* package (oamg#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 4, 2021
@drehak
Release 0.13.0
7639a39 
## Packaging
- Bump required leapp-framework capability to 1.4 (oamg#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (oamg#600)
- Fix remediation command for ipa-server removal (oamg#617)
- Fix crash due to missing network interfaces during upgrade phases (oamg#625)
- Fix error with /boot/efi existing on non-EFI systems (oamg#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (oamg#503)
- Allow upgrade with SCA enabled manifest (oamg#615)
- Add actors to migrate Quagga to FRR (oamg#467)
- Add stable uniq Key id for every dialog (oamg#618)
- Respect the *kernel-rt* package (oamg#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
pirat89 pushed a commit that referenced this pull request Feb 4, 2021
@drehak @pirat89
Release 0.13.0
d69b831 
## Packaging
- Bump required leapp-framework capability to 1.4 (#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (#600)
- Fix remediation command for ipa-server removal (#617)
- Fix crash due to missing network interfaces during upgrade phases (#625)
- Fix error with /boot/efi existing on non-EFI systems (#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (#587)
- Fix syntax error in upgrade script (#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (#503)
- Allow upgrade with SCA enabled manifest (#615)
- Add actors to migrate Quagga to FRR (#467)
- Add stable uniq Key id for every dialog (#618)
- Respect the *kernel-rt* package (#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirat89 pirat89 pirat89 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rezney @leapp-bot @pirat89