Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the FSTAB file for the deprecated / removed XFS mount options. #639

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Check the FSTAB file for the deprecated / removed XFS mount options. #639

merged 1 commit into from
Feb 4, 2021

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Jan 27, 2021

Some mount options for XFS have been deprecated on RHEL 7 and already
removed on RHEL 8. If any such an option is present in the FSTAB,
it's impossible to boot the RHEL 8 system without the manual update
of the file.

Check whether any of these options are present in the FSTAB file
and inhibit the upgrade in such a case.

@pirat89 pirat89 added the bug Something isn't working label Jan 27, 2021
@pirat89 pirat89 requested a review from Rezney January 27, 2021 22:30
@leapp-bot
Copy link
Collaborator

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the
Leapp Guidelines and must pass all tests in order to be mergable.

If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run unit tests, copr build and e2e tests in OAMG CI
  • e2e tests to run unit tests, copr build and end-to-end tests in Murphy CI (OAMG members only) [OLD PIPELINE]
  • review please to notify leapp developers of review request

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@Rezney
Copy link
Member

Rezney commented Jan 28, 2021

Seems to be working fine after a simple test. Will approve it after the tests passes.

@examon
Copy link
Member

examon commented Jan 28, 2021

leapp-ci build

1 similar comment
@examon
Copy link
Member

examon commented Jan 28, 2021

leapp-ci build

@Rezney
Copy link
Member

Rezney commented Jan 28, 2021

One test is still failing...

@pirat89
Copy link
Member Author

pirat89 commented Jan 28, 2021

@Rezney it's not test. it's waiting for #637 - tests already passed so I am going to merge it and rebase.

Rezney
Rezney previously approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@Rezney Rezney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@pirat89
Copy link
Member Author

pirat89 commented Feb 3, 2021

just rebase against the master, re-approval please @Rezney

Rezney
Rezney previously approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@Rezney Rezney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@drehak drehak mentioned this pull request Feb 4, 2021
Merged
@pirat89
Check the FSTAB file for the deprecated / removed XFS mount options.
3a3f45f 
Some mount options for XFS have been deprecated on RHEL 7 and already
removed on RHEL 8. If any such an option is present in the FSTAB,
it's impossible to boot the RHEL 8 system without the manual update
of the file.

Check whether any of these options are present in the FSTAB file
and inhibit the upgrade in such a case.
Rezney
Rezney approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@Rezney Rezney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reapproved

@AloisMahdal
Copy link

As of

  • leapp-repository-0.12.0-0.202102041559Z.3a3f45f.inhibit_fstab.PR639.el7_8.noarch

the upgrade is inhibited when any of the listed option is present:

Risk Factor: high (inhibitor)
Title: Deprecated XFS mount options present in FSTAB.
Summary: Some XFS mount options are not supported on RHEL 8 and prevent system from booting correctly if any of the reported XFS options are used. filesystem:
    - irixsgid
    - barrier
    - ihashsize
    - osyncisdsync
    - delaylog
    - nobarrier
    - nodelaylog
    - osyncisosync.
Remediation: [hint] Drop the following mount options from the /etc/fstab file for any XFS filesystem: irixsgid.
Key: bf735cd06346cf3794b670646d307d6faaa14a80

That is, QE verification passed.

@pirat89
Copy link
Member Author

pirat89 commented Feb 4, 2021

Merging after the QE verification. Skpping rest of the e2e tests.

@pirat89 pirat89 merged commit 1fd9fae into oamg:master Feb 4, 2021
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 4, 2021
@drehak
Release 0.13.0
bdcdddb 
## Packaging
- Bump required leapp-framework capability to 1.4 (oamg#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (oamg#600)
- Fix remediation command for ipa-server removal (oamg#617)
- Fix crash due to missing network interfaces during upgrade phases (oamg#625)
- Fix error with /boot/efi existing on non-EFI systems (oamg#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (oamg#503)
- Allow upgrade with SCA enabled manifest (oamg#615)
- Add actors to migrate Quagga to FRR (oamg#467)
- Add stable uniq Key id for every dialog (oamg#618)
- Respect the *kernel-rt* package (oamg#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
drehak added a commit to drehak/leapp-repository that referenced this pull request Feb 4, 2021
@drehak
Release 0.13.0
7639a39 
## Packaging
- Bump required leapp-framework capability to 1.4 (oamg#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (oamg#600)
- Fix remediation command for ipa-server removal (oamg#617)
- Fix crash due to missing network interfaces during upgrade phases (oamg#625)
- Fix error with /boot/efi existing on non-EFI systems (oamg#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (oamg#503)
- Allow upgrade with SCA enabled manifest (oamg#615)
- Add actors to migrate Quagga to FRR (oamg#467)
- Add stable uniq Key id for every dialog (oamg#618)
- Respect the *kernel-rt* package (oamg#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
pirat89 pushed a commit that referenced this pull request Feb 4, 2021
@drehak @pirat89
Release 0.13.0
d69b831 
## Packaging
- Bump required leapp-framework capability to 1.4 (#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (#600)
- Fix remediation command for ipa-server removal (#617)
- Fix crash due to missing network interfaces during upgrade phases (#625)
- Fix error with /boot/efi existing on non-EFI systems (#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (#587)
- Fix syntax error in upgrade script (#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (#503)
- Allow upgrade with SCA enabled manifest (#615)
- Add actors to migrate Quagga to FRR (#467)
- Add stable uniq Key id for every dialog (#618)
- Respect the *kernel-rt* package (#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
@pirat89 pirat89 deleted the inhibit-fstab branch May 5, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rezney Rezney Rezney approved these changes

@vinzenz vinzenz Awaiting requested review from vinzenz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pirat89 @leapp-bot @Rezney @examon @AloisMahdal @vinzenz