Split the CI for Cygwin into 2 jobs rather than 2 workflows #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert to inputs.cygwin being a boolean since the two Cygwin workflows are run sequentially (and hence the second workflow can no longer expect the compiler to have been built and cached by the first workflow, since trunk can be updated while the first part is running)
Use "needs:" to ensure they are sequentially (to reuse the compiler built in the first part for the second) and still having a full 6 hours timeout each "always()" ensures that "part2" runs even if a test failed in "part1"
jmid
approved these changes
Mar 22, 2023
|
All green - for the first time in a while! I'll merge immediately 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found out that stating that the second job
needsthe first, it is not skipped. This allows us to get one workflow for the whole test suite on Cygwin (but unfortunately it can take quite some time, with 2 × 6 hours of timeout).