Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Cygwin CI workflow parts #420

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Merge Cygwin CI workflow parts #420

merged 3 commits into from
Dec 12, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Dec 8, 2023

This PR merges the two GitHub actions workflow parts for Cygwin into a single one.

Initially, the split was done out of necessity in #305 and #313 as the Cygwin port initially was too slow to complete within the 6h timeout!

Since then we have seen general OCaml (GC) improvements, meaning that the 2-part Cygwin CI workflow would complete in about 2x45m, and thus opening up for a workflow merge incl. saving time on storing and restoring the state.

Finally I offer two data points from a trial run of this branch:

@jmid
Copy link
Collaborator Author

jmid commented Dec 11, 2023

Cygwin-wise, the 4 merged workflows completed 69m, 76m, 79m, and 84m, thus confirming that merging should be OK.
We may even consider lowering the time out at some point...

With the removal of the bytes dependency in qcheck-core.0.21.3 we had a record low 12m run on Linux testing 5.1 - and 12 complete GA runs of <=20m! 🎉

CI summary:

Out of 59 workflows 4 failed with 3 genuine issues and 1 CI issue.

Copy link
Collaborator

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
And it’s really nice to be able to go back to a single job for those workflows, juggling with the timeout was unnecessarily complex.
Little suggestion: if we drop all that two-job logic on the .yml side, we might just as well as drop the skipnextjob lines on the dune side: shym@e7d04de
What do you think?

@shym
Copy link
Collaborator

shym commented Dec 11, 2023

I updated the PR according to my suggestion :-)

@jmid
Copy link
Collaborator Author

jmid commented Dec 12, 2023

Of the 3 Cygwin runs 3 completed in 80m, 87m, 127m and 1 timed out after 6h because of a deadlock.

CI summary:

Out of 59 workflows 13 failed, with 10 triggering genuine errors, 1 false alarm, and 2 internal CI failures

@jmid jmid merged commit 913c230 into main Dec 12, 2023
38 of 49 checks passed
@jmid jmid deleted the merge-cygwin-parts branch December 12, 2023 13:20
@jmid
Copy link
Collaborator Author

jmid commented Dec 14, 2023

CI summary for merge to main:

Out of 36 workflows 5 failed with 3 genuine issues and 2 CI setup-related failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants