Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] yojson and yojson-five (2.2.0) #25994

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Leonidas-from-XIV
Copy link
Contributor

Yojson is an optimized parsing and printing library for the JSON format

CHANGES:

2024-05-31

Added

Removed

CHANGES:

*2024-05-31*

### Added

- Added support for JSON5 (@dhilst, @gorm-issuu, @gertsonderby, ocaml-community/yojson#152)

### Removed

- Remove CPPO dependency to make the Yojson installation lighter
  (@Leonidas-from-XIV, ocaml-community/yojson#175)
@mseri
Copy link
Member

mseri commented Jun 3, 2024

There are some timeout issues which I don't think are your fault, we started seeing them recently.

The only real new failure that I seem to see is


#=== ERROR while compiling sarif.0.2.0 ========================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.5.2.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/sarif.0.2.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p sarif -j 255 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/sarif-7-234217.env
# output-file          ~/.opam/log/sarif-7-234217.out
### output ###
# File "test/dune", line 3, characters 23-40:
# 3 |  (libraries sarif core ppx_expect.common ppx_expect.config ppx_expect.config_types)
#                            ^^^^^^^^^^^^^^^^^
# Error: Library "ppx_expect.common" not found.
# -> required by library "test_sarif" in _build/default/test
# -> required by
#    _build/default/test/.test_sarif.inline-tests/inline_test_runner_test_sarif.exe
# -> required by alias test/runtest in test/dune:4

did you use to have ppx_expect tests?

Anyway this can be fixed separately

@Leonidas-from-XIV
Copy link
Contributor Author

did you use to have ppx_expect tests?

Not in Yojson, I don't think we ever did. Looking at #26009 (thanks!) I am also wondering how sarif ever worked, because neither yojson nor cppo ever depended on ppx_expect, so it wasn't accidentally captured as dependency via a transitive dependency from the yojson side of things.

@mseri mseri merged commit c45f5ba into ocaml:master Jun 3, 2024
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Jun 3, 2024

Thanks

@Leonidas-from-XIV Leonidas-from-XIV deleted the release-yojson-2.2.0 branch June 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants