Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yojson-bench unavailable #26003

Conversation

Leonidas-from-XIV
Copy link
Contributor

There is no point in ever installing this package, it's just a hack to be able to install development dependencies and set ocaml versions (core_bench which includes a lot of dependencies that we don't want to have in yojson). In new releases like in #25994 I try not to submit the package in the first place.

Another option is to just delete it from opam-repository altogether which is probably more useful as it then doesn't clog up search results etc. but I'll refer to the maintainers.

There is no point in ever installing that package, it's just a hack to
be able to install development dependencies.
@avsm
Copy link
Member

avsm commented May 31, 2024

What's the harm in leaving it available? It's fairly common to quickly try a few benchmarks with experimental compiler variants, and it's useful to have some benchmarks lying around for that in the opam repository.

@Leonidas-from-XIV
Copy link
Contributor Author

Not much, but they're not really supported by the Yojson authors for other users and there's no guarantees that they have any use for people who are not Yojson developers. It's a bit like stdune which is also not meant to be used by others and has no guarantees.

If you prefer to keep them, that's fine with me.

@mseri
Copy link
Member

mseri commented Jun 5, 2024

We are going to keep them for now, and then we will move it with the other unmaintained packages to the opam-repository archive once the policy is implemented. We have noted the package down in https://github.com/ocaml/opam-repository/wiki/Known-stale-packages-to-archive

@mseri mseri closed this Jun 5, 2024
@Leonidas-from-XIV Leonidas-from-XIV deleted the yojson-bench-unavailable branch June 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants