Correct display of dir separator on Windows #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected messages which had hard-coded forward slashes in messages (e.g. ~/.opam) either to use Filename.dir_sep (for simple cases like that) or Filename.concat to build the display properly. Messages on Windows should always use backslashes (and certainly not end up displaying a mix). OpamFilename.create and OpamFilename.Dir.of_string both normalise forward-slash to back-slash on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected messages which had hard-coded forward slashes in messages (e.g.
~/.opam) either to useFilename.dir_sep(for simple cases like that) orFilename.concatto build the display properly. Messages on Windows should always use backslashes (and certainly not end up displaying a mix).OpamFilename.createandOpamFilename.Dir.of_string(already) both normalise forward-slash to back-slash on Windows.Note that while Windows doesn't have a concept of
~in the normal way, it's not unreasonable to assume it (Vim-for-Windows, for example, automatically displays~if you set%HOME%, and I have another shell-related commit which sets%HOME%for opam users)