Add missing Cmdliner.Manpage.escape calls #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch to including Windows separators requires backslashes to be escaped.
Need to upgrade cmdliner requirement ? |
|
Maybe not. |
|
Oops - my bad. I think I must have done that soon after tracking down that escaping bug and so had the internal module name in my mental cache! |
dra27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3893 uses Windows separators in various opam messages - the ones which are cmdliner terms need to be escaped, which this PR addresses. This PR is also a prerequisite of #3902.