This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
[BB-3173] Fix calculating vacations and commitments #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it is
This contains the following changes:
3.9
and Django to3.1.3
and bumps dependencies (minor changes; unfortunately we cannot use PEP 585, because mypy does not support it yet).Testing instructions
.env
andfrontend/env.local
(you can find them in a comment on the ticket).docker-compose -f local.yml up --build
.docker-compose -f local.yml logs django
.docker-compose -f local.yml exec django python manage.py migrate
.frontend
directory and runnpm i && npm start
._get_vacation_for_day
's docstring. Change your timezone here to a negative one to see how it impacts these cases.