Skip to content
This repository has been archived by the owner on Oct 30, 2021. It is now read-only.

[BB-3173] Fix vacations for negative timezones #61

Merged

Conversation

Agrendalath
Copy link
Member

This fixes a bug with calculating vacations for negative timezones from #59. That PR did not invert the division for negative timezones, so these cases were not being classified correctly:

  1. Negative timezone, non-overlapping day, vacations at the last day of the active sprint. These were counted as a part of the next sprint instead of the active one.
  2. Negative timezone, non-overlapping day, vacations at the last day of the next sprint. These were counted as a part of the future next sprint instead of the next one.

Testing instructions:

  1. Check that the tests are passing.

@Agrendalath Agrendalath added the bug Something isn't working label Nov 24, 2020
@Agrendalath Agrendalath self-assigned this Nov 24, 2020
@Agrendalath Agrendalath changed the title Fix vacations for negative timezones [BB-3173] Fix vacations for negative timezones Nov 24, 2020
Copy link
Member

@0x29a 0x29a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I checked that tests are passing.
  • I was rereading diff until I understood what caused bug and why change fixes it.
  • Includes documentation.

@Agrendalath Agrendalath merged commit f7078f6 into master Nov 25, 2020
@Agrendalath Agrendalath deleted the agrendalath/bb-3173-fix_vacations_for_negative_timezones branch November 25, 2020 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants