perf: add heap benchmark and reduce allocations #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
============================================
- Coverage 93.71% 93.20% -0.52%
- Complexity 429 437 +8
============================================
Files 40 40
Lines 1019 1016 -3
Branches 72 84 +12
============================================
- Hits 955 947 -8
- Misses 40 42 +2
- Partials 24 27 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Oct 10, 2024
| @@ -0,0 +1,239 @@ | |||
| [INFO] Scanning for projects... | |||
There was a problem hiding this comment.
I don't care if we commit this or not, but I think we should for records.
toddbaert
requested review from
justinabrahms,
beeme1mr,
thisthat,
aepfli and
liran2000
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Oct 10, 2024
Comment on lines
41
to
46
| protected Map<String, Value> getAttributes() { | ||
| if (attributes == null) { | ||
| attributes = new HashMap<>(); | ||
| } | ||
| return attributes; | ||
| } |
There was a problem hiding this comment.
perf: lazily initialize.
There was a problem hiding this comment.
Excellent point. I've reverted this because it's not a even a substantial savings. The bench result barely changes.
toddbaert
commented
Oct 10, 2024
Comment on lines
+43
to
+47
| for (Hook hook : hooks) { | ||
| if (hook.supportsFlagValueType(flagValueType)) { | ||
| executeChecked(hook, hookCode, hookMethod); | ||
| } | ||
| } |
toddbaert
commented
Oct 10, 2024
Comment on lines
+66
to
+70
| for (Hook hook : hooks) { | ||
| if (hook.supportsFlagValueType(flagValueType)) { | ||
| hookCode.accept(hook); | ||
| } | ||
| } |
toddbaert
commented
Oct 10, 2024
Comment on lines
+77
to
+89
| List<Hook> reversedHooks = new ArrayList<>(hooks); | ||
| Collections.reverse(reversedHooks); | ||
| EvaluationContext context = hookCtx.getCtx(); | ||
| for (Hook hook : reversedHooks) { | ||
| if (hook.supportsFlagValueType(flagValueType)) { | ||
| Optional<EvaluationContext> optional = Optional.ofNullable(hook.before(hookCtx, hints)) | ||
| .orElse(Optional.empty()); | ||
| if (optional.isPresent()) { | ||
| context = context.merge(optional.get()); | ||
| } | ||
| } | ||
| } | ||
| return context; |
toddbaert
commented
Oct 10, 2024
Comment on lines
+64
to
+71
| private static Map<String, Value> copyAttributes(Map<String, Value> in) { | ||
| Map<String, Value> copy = new HashMap<>(); | ||
| for (Entry<String, Value> entry : in.entrySet()) { | ||
| copy.put(entry.getKey(), | ||
| Optional.ofNullable(entry.getValue()).map((Value val) -> val.clone()).orElse(null)); | ||
| } | ||
| return copy; | ||
| } |
There was a problem hiding this comment.
perf: common, non-stream method to copy.
toddbaert
commented
Oct 10, 2024
Comment on lines
+117
to
+121
| if (overridingContext == null || overridingContext.isEmpty()) { | ||
| return this; | ||
| } | ||
| if (this.isEmpty()) { | ||
| return overridingContext; |
There was a problem hiding this comment.
perf: quit early with less HashMap instantiations
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
liran2000
reviewed
Oct 10, 2024
|
|
||
| AbstractStructure() { | ||
| this.attributes = new HashMap<>(); | ||
| // intentionally don't initialize the attributes - do this lazily |
There was a problem hiding this comment.
Reverted for: #1156 (comment)
Comment on lines
41
to
46
| protected Map<String, Value> getAttributes() { | ||
| if (attributes == null) { | ||
| attributes = new HashMap<>(); | ||
| } | ||
| return attributes; | ||
| } |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
liran2000
approved these changes
Oct 10, 2024
beeme1mr
approved these changes
Oct 10, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
aepfli
approved these changes
Oct 15, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces allocations of heap objects by ~70% for most use-cases. It does this by removing some usage of the streams API in some hotspots, and also being more efficient with
HashMapsand context merging.Benchmark results before/after these changes:
The performance optimizations are not very cool or exciting; mostly try to avoid creating unnecessary
HashMapsand don't use streams in hot paths (like context merging in hooks).