perf: add heap benchmark and reduce allocations #1156
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,15 @@ | |
| @SuppressWarnings({ "PMD.BeanMembersShouldSerialize", "checkstyle:MissingJavadocType" }) | ||
| abstract class AbstractStructure implements Structure { | ||
|
|
||
| private Map<String, Value> attributes; | ||
|
|
||
| @Override | ||
| public boolean isEmpty() { | ||
| return attributes == null || attributes.size() == 0; | ||
| } | ||
|
|
||
| AbstractStructure() { | ||
| // intentionally don't initialize the attributes - do this lazily | ||
|
There was a problem hiding this comment. Reverted for: #1156 (comment) |
||
| } | ||
|
|
||
| AbstractStructure(Map<String, Value> attributes) { | ||
|
|
@@ -32,4 +37,11 @@ public Map<String, Object> asObjectMap() { | |
| (accumulated, entry) -> accumulated.put(entry.getKey(), convertValue(entry.getValue())), | ||
| HashMap::putAll); | ||
| } | ||
|
|
||
| protected Map<String, Value> getAttributes() { | ||
| if (attributes == null) { | ||
| attributes = new HashMap<>(); | ||
| } | ||
| return attributes; | ||
| } | ||
|
There was a problem hiding this comment. perf: lazily initialize. There was a problem hiding this comment. Excellent point. I've reverted this because it's not a even a substantial savings. The bench result barely changes. |
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care if we commit this or not, but I think we should for records.