Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Helm: Allow setting of tolerations on multiple jobs #2036

Closed
wants to merge 8 commits into from
Closed

feat: Helm: Allow setting of tolerations on multiple jobs #2036

wants to merge 8 commits into from

Conversation

resnostyle
Copy link
Contributor

Signed-off-by: Bryan Pearson bpearson@morningconsult.com

Setting tolerations on multiple jobs, so they can run in environments which require tolerations to be set.

sozercan
sozercan approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe
Copy link
Contributor

Thanks for the PR! Should we document the new parameter here:

https://github.com/open-policy-agent/gatekeeper/tree/master/cmd/build/helmify/static#parameters

?

chewong
chewong reviewed May 6, 2022
View reviewed changes
Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise LGTM 😄

cmd/build/helmify/static/templates/webhook-configs-pre-delete.yaml Outdated
@@ -42,6 +42,9 @@ spec:
{{- end }}
securityContext:
{{- toYaml .Values.preUninstall.securityContext | nindent 10 }}
tolerations:
{{- toYaml .Values.preUninstall.deleteWebhookConfigurations.tolerations | nindent 8 }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to resolve this nit.

maxsmythe
maxsmythe requested changes May 7, 2022
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking "request changes" for docs change

@willbeason willbeason changed the title Helm: Allow setting of tolerations on multiple jobs feat: Helm: Allow setting of tolerations on multiple jobs May 31, 2022
Bryan Pearson and others added 2 commits June 21, 2022 09:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #2036 (1ef1e3a) into master (52db6a7) will increase coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   54.27%   54.55%   +0.28%     
==========================================
  Files         111      111              
  Lines        9529     9529              
==========================================
+ Hits         5172     5199      +27     
+ Misses       3956     3937      -19     
+ Partials      401      393       -8
Flag Coverage Δ
unittests 54.55% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 59.95% <0.00%> (+5.51%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52db6a7...1ef1e3a. Read the comment docs.

fix: remove extra line
31ed1cf 
Signed-off-by: Bryan Pearson <bpearson@morningconsult.com>
@resnostyle resnostyle force-pushed the feature/allow-namespace-post-install-tolerations branch from 9223ca1 to 31ed1cf Compare August 1, 2022 15:32
@resnostyle
Copy link
Contributor Author

Thanks for the PR! Should we document the new parameter here:

https://github.com/open-policy-agent/gatekeeper/tree/master/cmd/build/helmify/static#parameters

?

Added documentation.

@sozercan sozercan requested a review from maxsmythe August 1, 2022 22:42
maxsmythe
maxsmythe approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stek29
Copy link
Contributor

stek29 commented Aug 21, 2022

isn't this resolved by #2202?

@ritazh
Copy link
Member

ritazh commented Aug 22, 2022

isn't this resolved by #2202?

Thanks @stek29! Closing this as it has been superseded by #2202

@ritazh ritazh closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewong chewong chewong left review comments

@sozercan sozercan sozercan approved these changes

@maxsmythe maxsmythe maxsmythe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@resnostyle @maxsmythe @codecov-commenter @stek29 @ritazh @sozercan @chewong