-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add options for hook jobs #2202
Conversation
8fa0a5f
to
e06950c
Compare
8bbb4c1
to
b0e46f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Overall, LGTM
pending readme updates.
You can update https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md then run make manifests
to make sure the changes land in manifests_staging
I'll review after README updates |
4f477e6
to
febd097
Compare
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
- Coverage 54.50% 54.33% -0.17%
==========================================
Files 111 111
Lines 9535 9535
==========================================
- Hits 5197 5181 -16
- Misses 3942 3954 +12
- Partials 396 400 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
add resources, affinity, nodeSelector, tolerations Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
@maxsmythe I've updated the readme :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you again!
* feat(helm): add options for hook jobs (fix open-policy-agent#2200) add resources, affinity, nodeSelector, tolerations Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks> * docs: update Chart README Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
What this PR does / why we need it:
it adds a way to set:
resources
affinity
nodeSelector
tolerations
on all of the hook jobs
Which issue(s) this PR fixes:
Fixes #2200
Special notes for your reviewer:
it also changes upgradeCRDs.affinity/upgradeCRDs.tolerations added recently be consistent with other parameters.
I haven't updated the README because I'm not sure on what would be the correct way to do it. I've opened an issue on this: #2201