[chore] Remove all direct usage of component.host.GetExporters #32498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
github-actions
bot
added
connector/servicegraph
processor/routing
mx-psi
approved these changes
Apr 18, 2024
evan-bradley
approved these changes
Apr 18, 2024
mx-psi
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jul 25, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Adds a note to the `component.Host` interface documenting that components may require additional interfaces. I think this is the only sustainable pattern post 1.0, since we won't be able to add any new methods to the `component.Host` interface. This pattern is also used today by: - The zpages extension (https://github.com/open-telemetry/opentelemetry-collector/blob/91f13c309d00eef5b997a2e810effb2a4ccd95d4/extension/zpagesextension/zpagesextension.go#L58-L66) - The receiver creator (after open-telemetry/opentelemetry-collector-contrib/pull/34234) - Some contrib components (open-telemetry/opentelemetry-collector-contrib/pull/32498) #### Link to tracking issue Fixes #10181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes all direct use of the
component.Host.GetExportersfunction so that it can be removed from the interface.Link to tracking Issue:
Works towards open-telemetry/opentelemetry-collector#7370