Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove all direct usage of component.host.GetExporters #32498

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[chore] Remove all direct usage of component.host.GetExporters #32498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove all direct usage of component.host.GetExporters
  • Loading branch information
@TylerHelmuth
TylerHelmuth committed Apr 17, 2024
commit dad7d63bc92deaf20e981bd71de1516999183995
10 changes: 9 additions & 1 deletion connector/servicegraphconnector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,19 @@ func newConnector(set component.TelemetrySettings, config component.Config) *ser
}
}

type getExporters interface {
GetExporters() map[component.DataType]map[component.ID]component.Component
}

func (p *serviceGraphConnector) Start(_ context.Context, host component.Host) error {
p.store = store.NewStore(p.config.Store.TTL, p.config.Store.MaxItems, p.onComplete, p.onExpire)

if p.metricsConsumer == nil {
exporters := host.GetExporters() //nolint:staticcheck
ge, ok := host.(getExporters)
if !ok {
return fmt.Errorf("unable to get exporters")
}
exporters := ge.GetExporters()

// The available list of exporters come from any configured metrics pipelines' exporters.
for k, exp := range exporters[component.DataTypeMetrics] {
Expand Down
11 changes: 10 additions & 1 deletion processor/routingprocessor/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package routingprocessor // import "github.com/open-telemetry/opentelemetry-coll

import (
"context"
"fmt"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
Expand Down Expand Up @@ -66,8 +67,16 @@ func newLogProcessor(settings component.TelemetrySettings, config component.Conf
}, nil
}

type getExporters interface {
GetExporters() map[component.DataType]map[component.ID]component.Component
}

func (p *logProcessor) Start(_ context.Context, host component.Host) error {
err := p.router.registerExporters(host.GetExporters()[component.DataTypeLogs]) //nolint:staticcheck
ge, ok := host.(getExporters)
if !ok {
return fmt.Errorf("unable to get exporters")
}
err := p.router.registerExporters(ge.GetExporters()[component.DataTypeLogs])
if err != nil {
return err
}
Expand Down
7 changes: 6 additions & 1 deletion processor/routingprocessor/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package routingprocessor // import "github.com/open-telemetry/opentelemetry-coll

import (
"context"
"fmt"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
Expand Down Expand Up @@ -67,7 +68,11 @@ func newMetricProcessor(settings component.TelemetrySettings, config component.C
}

func (p *metricsProcessor) Start(_ context.Context, host component.Host) error {
err := p.router.registerExporters(host.GetExporters()[component.DataTypeMetrics]) //nolint:staticcheck
ge, ok := host.(getExporters)
if !ok {
return fmt.Errorf("unable to get exporters")
}
err := p.router.registerExporters(ge.GetExporters()[component.DataTypeMetrics])
if err != nil {
return err
}
Expand Down
7 changes: 6 additions & 1 deletion processor/routingprocessor/traces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package routingprocessor // import "github.com/open-telemetry/opentelemetry-coll

import (
"context"
"fmt"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
Expand Down Expand Up @@ -68,7 +69,11 @@ func newTracesProcessor(settings component.TelemetrySettings, config component.C
}

func (p *tracesProcessor) Start(_ context.Context, host component.Host) error {
err := p.router.registerExporters(host.GetExporters()[component.DataTypeTraces]) //nolint:staticcheck
ge, ok := host.(getExporters)
if !ok {
return fmt.Errorf("unable to get exporters")
}
err := p.router.registerExporters(ge.GetExporters()[component.DataTypeTraces])
if err != nil {
return err
}
Expand Down
12 changes: 11 additions & 1 deletion receiver/k8sclusterreceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package k8sclusterreceiver // import "github.com/open-telemetry/opentelemetry-co
import (
"context"
"errors"
"fmt"
"time"

"go.opentelemetry.io/collector/component"
Expand Down Expand Up @@ -36,14 +37,23 @@ type kubernetesReceiver struct {
obsrecv *receiverhelper.ObsReport
}

type getExporters interface {
GetExporters() map[component.DataType]map[component.ID]component.Component
}

func (kr *kubernetesReceiver) Start(ctx context.Context, host component.Host) error {
ctx, kr.cancel = context.WithCancel(ctx)

if err := kr.resourceWatcher.initialize(); err != nil {
return err
}

exporters := host.GetExporters() //nolint:staticcheck
ge, ok := host.(getExporters)
if !ok {
return fmt.Errorf("unable to get exporters")
}
exporters := ge.GetExporters()

if err := kr.resourceWatcher.setupMetadataExporters(
exporters[component.DataTypeMetrics], kr.config.MetadataExporters); err != nil {
return err
Expand Down
Loading