-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build to use docker compose
#24
Comments
Hey @mic-max, what's the status of this? Do you have any key blockers? |
Hello @mic-max, I've tried to reach out to you via Slack, but I guess here it is better, because we can have it documented. I've taken a look at the PR #33 and I saw that there was a lot of changes regarding env vars, dockerfiles and proto files. Don't you think it would be better to split them up into small PRs? I've tried to set it up locally with docker compose and I couldn't make it work. I've taken your docker compose as start and created a simpler one, just to make the app run. If you agree I can open a PR, and then we can do the changes you have done in your PR gradually. What do you think? I don't want to step on your toes, please don't get me wrong. |
+1 to smaller, targeted PRs. @cijothomas 😉 |
The
docker compose build
will build all services on all platformsdocker-compose.yml
at the root of the repositoryDockerfile
filesdemo.proto
fileReferences
The text was updated successfully, but these errors were encountered: