Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/docker compose #74

Merged
merged 3 commits into from
May 31, 2022
Merged

Feature/docker compose #74

merged 3 commits into from
May 31, 2022

Conversation

julianocosta89
Copy link
Member

Partially fixes #24 .

Changes

  • Added .env file with all environment variables which will be used by docker compose.
  • Added to README the steps on how to deploy using docker compose.
  • Added compose.yml file with all the configurations to start the webstore-demo-app.
  • Removed unused files
  • Renamed the src/otelcollector/conf.yml to src/otelcollector/otelcol-config.yml .
  • Updated otel-collector Jaeger exporter configuration with the new sintaxe: jaeger.insecure.true

@julianocosta89 julianocosta89 self-assigned this May 30, 2022
@julianocosta89 julianocosta89 requested a review from a team as a code owner May 30, 2022 20:18
@julianocosta89
Copy link
Member Author

I believe we should split #24 .

The docker compose is working and we should probably think in a way of testing it, to ensure future updates won't break it.

Besides that, the following tasks should be split into separated tickets, as they are not related to the docker compose task:

  • Adapt all services Dockerfile files
  • Remove duplication of demo.proto file
  • Compile protobuf source files during build

@julianocosta89 julianocosta89 added the enhancement New feature or request label May 30, 2022
@cartersocha
Copy link
Contributor

Just got this to run locally on my mac & verified the jaeger trace / console output.

Took me about 11-12 mins to from clone to the end output. Pretty cool to be able to spin it up so easily.

We'll need to start looking at the delta between current output & otel requirements.

LGTM.

@cartersocha
Copy link
Contributor

We can flesh out the docs in another pr

reyang
reyang approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cartersocha cartersocha merged commit 020564b into open-telemetry:main May 31, 2022
@julianocosta89 julianocosta89 deleted the feature/docker-compose branch May 31, 2022 05:38
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@julianocosta89
Feature/docker compose (open-telemetry#74)
ddbd421 
* Add docker compose

* Remove unused files

* Fix yaml lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@cartersocha cartersocha cartersocha approved these changes

Assignees

@julianocosta89 julianocosta89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate build to use docker compose
3 participants
@julianocosta89 @cartersocha @reyang