Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][chloggen] Run tests end-to-end #369

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

djaglowski
Copy link
Member

This PR increases test coverage by executing cobra commands directly. It also some new test cases and further validates expected outputs and errors.

@djaglowski djaglowski requested review from a team and dmitryax July 18, 2023 19:58
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 70.94% and project coverage change: +0.93 🎉

Comparison is base (db501f8) 60.69% compared to head (3a76020) 61.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   60.69%   61.63%   +0.93%     
==========================================
  Files          48       48              
  Lines        2315     2330      +15     
==========================================
+ Hits         1405     1436      +31     
+ Misses        758      743      -15     
+ Partials      152      151       -1     
Impacted Files Coverage Δ
chloggen/cmd/update.go 58.00% <58.00%> (+6.97%) ⬆️
chloggen/cmd/validate.go 68.42% <68.42%> (+21.36%) ⬆️
chloggen/cmd/new.go 78.78% <79.31%> (+17.49%) ⬆️
chloggen/cmd/root.go 92.00% <94.73%> (+38.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski merged commit 9228e92 into open-telemetry:main Jul 18, 2023
11 checks passed
@djaglowski djaglowski deleted the chloggen-test-commands branch July 18, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants