Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][chloggen] Rename 'Context' to 'Config' and move to dedicated package #370

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

djaglowski
Copy link
Member

This PR follows #368 and #369 to further prepare the chloggen tool for the introduction of a repo-level configuration file.

  • Rebrands the notion of a "Context" as a "Config", but stops short of actually introducing the config file.
  • Creates a chloggen/internal/config package and moves former "Context" files into this package.
  • Moves RepoRoot to cmd.repoRoot. The function is related to the "Context" of the tool, but as a "Config", it makes more sense that the value is provided.
  • Further normalize tests across sub functions.

@djaglowski djaglowski requested review from a team and dmitryax July 20, 2023 15:03
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.25 🎉

Comparison is base (9228e92) 61.63% compared to head (1855b57) 61.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   61.63%   61.88%   +0.25%     
==========================================
  Files          48       48              
  Lines        2330     2330              
==========================================
+ Hits         1436     1442       +6     
+ Misses        743      739       -4     
+ Partials      151      149       -2     
Impacted Files Coverage Δ
chloggen/cmd/root.go 81.25% <60.00%> (-10.75%) ⬇️
chloggen/cmd/update.go 64.00% <83.33%> (+6.00%) ⬆️
chloggen/cmd/new.go 78.78% <100.00%> (ø)
chloggen/cmd/validate.go 84.21% <100.00%> (+15.78%) ⬆️
chloggen/internal/chlog/entry.go 76.92% <100.00%> (ø)
chloggen/internal/config/config.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski changed the title [chore][chloggen] Rename 'Context' to 'Config' and move to dedicated directory [chore][chloggen] Rename 'Context' to 'Config' and move to dedicated package Jul 20, 2023
@djaglowski djaglowski merged commit d2e2f13 into open-telemetry:main Jul 20, 2023
9 checks passed
@djaglowski djaglowski deleted the chloggen-config branch July 20, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants