fix: Move @types/generic-pool from dependencies to devDependencies

[secondfry]

Which problem is this PR solving?

@opentelemetry/auto-instrumentations-node is unusable with TypeScript 5 due to following error:

> tsc && tsc-alias && touch .ok

error TS2688: Cannot find type definition file for 'generic-pool'.
  The file is in the program because:
    Entry point for implicit type library 'generic-pool'


Found 1 error.

Honesly, this fix is untested, but makes the most sense.

Short description of the changes

Move @types/generic-pool from dependencies to devDependencies.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: secondfry / name: Rustam @secondfry Gubaydullin (f2d8055)

[codecov]

Codecov Report

Merging #1563 (f2d8055) into main (a18b074) will decrease coverage by 3.42%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1563      +/-   ##
==========================================
- Coverage   96.06%   92.64%   -3.42%     
==========================================
  Files          14       86      +72     
  Lines         914     3874    +2960     
  Branches      199      705     +506     
==========================================
+ Hits          878     3589    +2711     
- Misses         36      285     +249     

see 100 files with indirect coverage changes

[blumamir]

Currently this package actually has to be a regular dependency as a type from this package is exported publicly from the package index.d.ts.

For end users installing this instrumentation in there application, typescript will attempt to import types from index.d.ts, as specified in package.json ):

  "types": "build/src/index.d.ts",

It will find this content in index.d.ts:

import GenericPoolInstrumentation from './instrumentation';
export { GenericPoolInstrumentation };
export default GenericPoolInstrumentation;
//# sourceMappingURL=index.d.ts.map

And will follow import GenericPoolInstrumentation from './instrumentation'; and find the following content in instrumentation.d.ts:

import { InstrumentationBase, InstrumentationConfig, InstrumentationNodeModuleDefinition } from '@opentelemetry/instrumentation';
import type * as genericPool from 'generic-pool';
export default class Instrumentation extends InstrumentationBase<typeof genericPool> {
    private _isDisabled;
    constructor(config?: InstrumentationConfig);
    init(): (InstrumentationNodeModuleDefinition<typeof genericPool> | InstrumentationNodeModuleDefinition<any>)[];
    private _acquirePatcher;
    private _poolWrapper;
    private _acquireWithCallbacksPatcher;
}
//# sourceMappingURL=instrumentation.d.ts.map

Once it hit the line

import type * as genericPool from 'generic-pool';

Typescript will emit an error as the types are missing.

You can follow this documentation to fix the issue. Basically what you need to do is to remove import type * as genericPool from 'generic-pool'; from instrumentation.ts and replace typeof genericPool in code with any.

[blumamir]

@secondfry - are you still interested in this?
Should we keep the PR open?

[blumamir]

fixed in #1637