fix(generic-pool): remove deps on types package for ts5 compatibility

[blumamir]

Which problem is this PR solving?

fix #1632

Replace: #1563 . Since the original PR seems inactive, and the fix is relatively easy, I opened this one.

Short description of the changes

removed the types from the instrumentation public generic functions, so they will not show up in instrumentation.d.ts. Now that the package is not part of the public API, it can safely be moved to dev dependency. This practice is common for instrumentation in the repo, as the type of the instrumentation's init function gives very little value (if any) and causes many problems.

After the change, instrumentation.d.ts which is imported from index.d.ts looks like this:

import { InstrumentationBase, InstrumentationConfig, InstrumentationNodeModuleDefinition } from '@opentelemetry/instrumentation';
export default class Instrumentation extends InstrumentationBase<any> {
    private _isDisabled;
    constructor(config?: InstrumentationConfig);
    init(): InstrumentationNodeModuleDefinition<any>[];
    private _acquirePatcher;
    private _poolWrapper;
    private _acquireWithCallbacksPatcher;
}
//# sourceMappingURL=instrumentation.d.ts.map

The generic-pool is not imported in types files.
More info here

[codecov]

Codecov Report

Merging #1637 (e310634) into main (b3d30af) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e310634 differs from pull request most recent head 52dcddd. Consider uploading reports for the commit 52dcddd to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         139      139           
  Lines        7112     7112           
  Branches     1427     1427           
=======================================
  Hits         6527     6527           
  Misses        585      585           

Files Changed	Coverage Δ
...nstrumentation-generic-pool/src/instrumentation.ts	40.00% <100.00%> (ø)

[blumamir]

@Flarna I know you have a lot of background in these kinds of issues.
Will appreciate your review on this PR when you have some cycles 🙏

Thank you

[pichlermarc]

Looks good, thanks for fixing this 🙂